Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 1641753003: Fix issues raised in CL 1645683003 by stichnot. (Closed)

Created:
4 years, 10 months ago by Karl
Modified:
4 years, 10 months ago
Reviewers:
Jim Stichnoth, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/DartARM32/assembler_arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/IceAssemblerARM32.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/IceInstARM32.cpp View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 10 months ago (2016-01-27 22:59:29 UTC) #3
Jim Stichnoth
lgtm
4 years, 10 months ago (2016-01-27 23:07:33 UTC) #4
Karl
4 years, 10 months ago (2016-01-27 23:39:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac186fd7a9deb000995bfe80e46cc900a4d51ff0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698