Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1645293003: [interpreter] Reachability is implied by live environment. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-control-flow
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Reachability is implied by live environment. The reachability of a bytecode is implied by a live environment reaching the bytecode during the abstract control flow simulation of the bytecode iteration perfromed by the graph builder. There is no need to compute it upfront anymore. Also, the upfront computation was only an approximation when it came to the reachability of an exception handler. This is why several tests for translation of exception handlers can now be enabled. R=oth@chromium.org Committed: https://crrev.com/83a2c8ed7f0f3070af6d23cd9c465bbf8c503df6 Cr-Commit-Position: refs/heads/master@{#33634}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -59 lines) Patch
M src/compiler/bytecode-branch-analysis.h View 4 chunks +3 lines, -8 lines 0 comments Download
M src/compiler/bytecode-branch-analysis.cc View 2 chunks +2 lines, -34 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M test/cctest/compiler/test-run-bytecode-graph-builder.cc View 2 chunks +13 lines, -14 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 10 months ago (2016-01-29 10:51:01 UTC) #2
oth
Less is more. lgtm.
4 years, 10 months ago (2016-02-01 09:06:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1645293003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1645293003/1
4 years, 10 months ago (2016-02-01 09:58:39 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 10:19:06 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:19:21 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/83a2c8ed7f0f3070af6d23cd9c465bbf8c503df6
Cr-Commit-Position: refs/heads/master@{#33634}

Powered by Google App Engine
This is Rietveld 408576698