Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: src/compiler/bytecode-branch-analysis.h

Issue 1645293003: [interpreter] Reachability is implied by live environment. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-control-flow
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler/bytecode-branch-analysis.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/bytecode-branch-analysis.h
diff --git a/src/compiler/bytecode-branch-analysis.h b/src/compiler/bytecode-branch-analysis.h
index e62150cf5f0332907295963e805cd19555098d0d..dd72b87cef0814fab28f109dbe03e352ee2dbe37 100644
--- a/src/compiler/bytecode-branch-analysis.h
+++ b/src/compiler/bytecode-branch-analysis.h
@@ -19,9 +19,9 @@ namespace compiler {
class BytecodeBranchInfo;
// A class for identifying the branch targets and their branch sites
-// within a bytecode array and also identifying which bytecodes are
-// reachable. This information can be used to construct the local
-// control flow logic for high-level IR graphs built from bytecode.
+// within a bytecode array. This information can be used to construct
+// the local control flow logic for high-level IR graphs built from
+// bytecode.
//
// NB This class relies on the only backwards branches in bytecode
// being jumps back to loop headers.
@@ -34,9 +34,6 @@ class BytecodeBranchAnalysis BASE_EMBEDDED {
// until this has been called.
void Analyze();
- // Returns true if the bytecode at |offset| is reachable.
- bool is_reachable(int offset) const { return reachable_.Contains(offset); }
-
// Returns true if there are any forward branches to the bytecode at
// |offset|.
bool forward_branches_target(int offset) const {
@@ -53,7 +50,6 @@ class BytecodeBranchAnalysis BASE_EMBEDDED {
private:
void AddBranch(int origin_offset, int target_offset);
- void AnalyzeExceptionHandlers();
// Offsets of bytecodes having a backward branch to the bytecode at |offset|.
const ZoneVector<int>* BackwardBranchesTargetting(int offset) const;
@@ -66,7 +62,6 @@ class BytecodeBranchAnalysis BASE_EMBEDDED {
ZoneMap<int, BytecodeBranchInfo*> branch_infos_;
Handle<BytecodeArray> bytecode_array_;
- BitVector reachable_;
Zone* zone_;
DISALLOW_COPY_AND_ASSIGN(BytecodeBranchAnalysis);
« no previous file with comments | « no previous file | src/compiler/bytecode-branch-analysis.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698