Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1646873004: [interpreter] Simplify BytecodeBranchAnalysis to minimum. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-reachability
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Simplify BytecodeBranchAnalysis to minimum. This simplifies the branch analysis we perform on the bytecode stream down to the bare minimum that we need to build graphs. Note that we still record all branch targets, even though only the backwards ones would be needed, but this is essentially for free and might be useful eventually. R=oth@chromium.org Committed: https://crrev.com/c207f10b09303a525a5e15a2a61f03efd2c300a1 Cr-Commit-Position: refs/heads/master@{#33635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -86 lines) Patch
M src/compiler/bytecode-branch-analysis.h View 3 chunks +10 lines, -20 lines 0 comments Download
M src/compiler/bytecode-branch-analysis.cc View 2 chunks +6 lines, -66 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
Michael Starzinger
4 years, 10 months ago (2016-01-29 12:16:49 UTC) #2
oth
lgtm
4 years, 10 months ago (2016-02-01 08:56:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1646873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1646873004/1
4 years, 10 months ago (2016-02-01 10:22:01 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-01 10:47:02 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 10:47:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c207f10b09303a525a5e15a2a61f03efd2c300a1
Cr-Commit-Position: refs/heads/master@{#33635}

Powered by Google App Engine
This is Rietveld 408576698