Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1641893004: [interpreter] Simplify graph builder control flow simulation. (Closed)

Created:
4 years, 10 months ago by Michael Starzinger
Modified:
4 years, 10 months ago
Reviewers:
Benedikt Meurer, oth
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-move-environment
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Simplify graph builder control flow simulation. This simplifies how the BytecodeGraphBuilder simulates control flow by reversing the propagation direction to forwards propagation. This is the same direction as the data flow which is also a forward propagation. In this way the analysis information needed at merge points is drastically reduced while still retaining the same simulation power. In short: We push down environments instead of pulling them. R=oth@chromium.org Committed: https://crrev.com/ee5b58d9f9dba341ca6d7103d26d07ad60f2720f Cr-Commit-Position: refs/heads/master@{#33633}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -98 lines) Patch
M src/compiler/bytecode-branch-analysis.h View 2 chunks +6 lines, -11 lines 0 comments Download
M src/compiler/bytecode-branch-analysis.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M src/compiler/bytecode-graph-builder.h View 1 2 chunks +7 lines, -12 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 5 chunks +23 lines, -68 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 10 months ago (2016-01-28 19:50:09 UTC) #1
oth
Nice redux. lgtm.
4 years, 10 months ago (2016-02-01 09:02:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641893004/20001
4 years, 10 months ago (2016-02-01 09:22:06 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-01 09:47:24 UTC) #8
commit-bot: I haz the power
4 years, 10 months ago (2016-02-01 09:47:51 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ee5b58d9f9dba341ca6d7103d26d07ad60f2720f
Cr-Commit-Position: refs/heads/master@{#33633}

Powered by Google App Engine
This is Rietveld 408576698