Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: test/cctest/compiler/test-run-bytecode-graph-builder.cc

Issue 1645293003: [interpreter] Reachability is implied by live environment. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_interpreter-cleanup-graph-builder-control-flow
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/compiler/test-run-bytecode-graph-builder.cc
diff --git a/test/cctest/compiler/test-run-bytecode-graph-builder.cc b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
index c24bcc907272f8a7ab2f6a414a91dede705ab1d7..d1ce501c52d3b23a472b66137332b5750a9fc168 100644
--- a/test/cctest/compiler/test-run-bytecode-graph-builder.cc
+++ b/test/cctest/compiler/test-run-bytecode-graph-builder.cc
@@ -1418,9 +1418,8 @@ TEST(BytecodeGraphBuilderTryCatch) {
Zone* zone = scope.main_zone();
ExpectedSnippet<0> snippets[] = {
- // TODO(mstarzinger): Fix cases where nothing throws.
- // {"var a = 1; try { a = 2 } catch(e) { a = 3 }; return a;",
- // {handle(Smi::FromInt(2), isolate)}},
+ {"var a = 1; try { a = 2 } catch(e) { a = 3 }; return a;",
+ {handle(Smi::FromInt(2), isolate)}},
{"var a; try { undef.x } catch(e) { a = 2 }; return a;",
{handle(Smi::FromInt(2), isolate)}},
{"var a; try { throw 1 } catch(e) { a = e + 2 }; return a;",
@@ -1451,19 +1450,19 @@ TEST(BytecodeGraphBuilderTryFinally1) {
ExpectedSnippet<0> snippets[] = {
{"var a = 1; try { a = a + 1; } finally { a = a + 2; }; return a;",
{handle(Smi::FromInt(4), isolate)}},
- // TODO(mstarzinger): Fix cases where nothing throws.
- // {"var a = 1; try { a = 2; return 23; } finally { a = 3 }; return a;",
- // {handle(Smi::FromInt(23), isolate)}},
+ {"var a = 1; try { a = 2; return 23; } finally { a = 3 }; return a;",
+ {handle(Smi::FromInt(23), isolate)}},
{"var a = 1; try { a = 2; throw 23; } finally { return a; };",
{handle(Smi::FromInt(2), isolate)}},
- // {"var a = 1; for (var i = 10; i < 20; i += 5) {"
- // " try { a = 2; break; } finally { a = 3; }"
- // "} return a + i;",
- // {handle(Smi::FromInt(13), isolate)}},
- // {"var a = 1; for (var i = 10; i < 20; i += 5) {"
- // " try { a = 2; continue; } finally { a = 3; }"
- // "} return a + i;",
- // {handle(Smi::FromInt(23), isolate)}},
+ {"var a = 1; for (var i = 10; i < 20; i += 5) {"
+ " try { a = 2; break; } finally { a = 3; }"
+ "} return a + i;",
+ {handle(Smi::FromInt(13), isolate)}},
+ {"var a = 1; for (var i = 10; i < 20; i += 5) {"
+ " try { a = 2; continue; } finally { a = 3; }"
+ "} return a + i;",
+ {handle(Smi::FromInt(23), isolate)}},
+ // TODO(mstarzinger): Investigate failure!
// {"var a = 1; try { a = 2;"
// " try { a = 3; throw 23; } finally { a = 4; }"
// "} catch(e) { a = a + e; } return a;",
« no previous file with comments | « src/compiler/bytecode-graph-builder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698