Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1644223006: Fix some more shorten-64-to-32 warnings: (Closed)

Created:
4 years, 10 months ago by Ivan Posva
Modified:
4 years, 10 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix some more shorten-64-to-32 warnings: - Remove duplicate check for javascript integer overflow. - Make sure the BitField class knows the type it is encoding into. BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/4f392df85ea116029c0c8aecbb68997e4d3c5a5c

Patch Set 1 #

Patch Set 2 : More BitField updates. #

Patch Set 3 : Update to ToT. #

Total comments: 5

Patch Set 4 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -128 lines) Patch
M runtime/platform/utils.h View 1 chunk +1 line, -8 lines 0 comments Download
M runtime/vm/bitfield.h View 1 2 3 2 chunks +16 lines, -15 lines 0 comments Download
M runtime/vm/bitfield_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/class_table.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/dart_api_state.h View 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/vm/deopt_instructions.h View 2 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/deopt_instructions.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +5 lines, -4 lines 0 comments Download
M runtime/vm/locations.h View 1 chunk +8 lines, -7 lines 0 comments Download
M runtime/vm/native_arguments.h View 1 2 2 chunks +6 lines, -4 lines 0 comments Download
M runtime/vm/object.h View 1 2 7 chunks +60 lines, -43 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/profiler.h View 1 chunk +10 lines, -8 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 4 chunks +11 lines, -10 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M runtime/vm/thread.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/timeline.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tools/observatory_tool.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Ivan Posva
4 years, 10 months ago (2016-02-02 18:19:39 UTC) #2
siva
lgtm https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h File runtime/vm/bitfield.h (right): https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h#newcode13 runtime/vm/bitfield.h:13: // an unsigned machine word. Maybe document what ...
4 years, 10 months ago (2016-02-02 19:18:50 UTC) #3
Florian Schneider
dbc: https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h File runtime/vm/bitfield.h (right): https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h#newcode13 runtime/vm/bitfield.h:13: // an unsigned machine word. s/an unsigned machine ...
4 years, 10 months ago (2016-02-02 20:46:58 UTC) #5
Ivan Posva
https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h File runtime/vm/bitfield.h (right): https://codereview.chromium.org/1644223006/diff/40001/runtime/vm/bitfield.h#newcode13 runtime/vm/bitfield.h:13: // an unsigned machine word. On 2016/02/02 19:18:50, siva ...
4 years, 10 months ago (2016-02-02 21:14:56 UTC) #6
Ivan Posva
4 years, 10 months ago (2016-02-02 21:58:11 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
4f392df85ea116029c0c8aecbb68997e4d3c5a5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698