Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(805)

Unified Diff: runtime/vm/native_arguments.h

Issue 1644223006: Fix some more shorten-64-to-32 warnings: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/locations.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/native_arguments.h
diff --git a/runtime/vm/native_arguments.h b/runtime/vm/native_arguments.h
index 028b58b5f34165af6fd4ee58653077fa0251a11c..8bb1d6e0ccdeddb4b3425b75f5e02f654bbc73a3 100644
--- a/runtime/vm/native_arguments.h
+++ b/runtime/vm/native_arguments.h
@@ -189,9 +189,11 @@ class NativeArguments {
kFunctionSize = 2,
kAutoSetupScopeBit = 26,
};
- class ArgcBits : public BitField<int, kArgcBit, kArgcSize> {};
- class FunctionBits : public BitField<int, kFunctionBit, kFunctionSize> {};
- class AutoSetupScopeBits : public BitField<int, kAutoSetupScopeBit, 1> {};
+ class ArgcBits : public BitField<intptr_t, int32_t, kArgcBit, kArgcSize> {};
+ class FunctionBits :
+ public BitField<intptr_t, int, kFunctionBit, kFunctionSize> {};
+ class AutoSetupScopeBits :
+ public BitField<intptr_t, int, kAutoSetupScopeBit, 1> {};
friend class Api;
friend class BootstrapNatives;
friend class Simulator;
@@ -226,7 +228,7 @@ class NativeArguments {
}
Thread* thread_; // Current thread pointer.
- int argc_tag_; // Encodes argument count and invoked native call type.
+ intptr_t argc_tag_; // Encodes argument count and invoked native call type.
RawObject*(*argv_)[]; // Pointer to an array of arguments to runtime call.
RawObject** retval_; // Pointer to the return value area.
};
« no previous file with comments | « runtime/vm/locations.h ('k') | runtime/vm/object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698