Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Side by Side Diff: runtime/vm/timeline.h

Issue 1644223006: Fix some more shorten-64-to-32 warnings: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address review comments. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/thread.h ('k') | tools/observatory_tool.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_TIMELINE_H_ 5 #ifndef VM_TIMELINE_H_
6 #define VM_TIMELINE_H_ 6 #define VM_TIMELINE_H_
7 7
8 #include "vm/allocation.h" 8 #include "vm/allocation.h"
9 #include "vm/bitfield.h" 9 #include "vm/bitfield.h"
10 #include "vm/os.h" 10 #include "vm/os.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 void set_pre_serialized_json(bool pre_serialized_json) { 275 void set_pre_serialized_json(bool pre_serialized_json) {
276 state_ = PreSerializedJSON::update(pre_serialized_json, state_); 276 state_ = PreSerializedJSON::update(pre_serialized_json, state_);
277 } 277 }
278 278
279 enum StateBits { 279 enum StateBits {
280 kEventTypeBit = 0, // reserve 4 bits for type. 280 kEventTypeBit = 0, // reserve 4 bits for type.
281 kPreSerializedJSON = 4, 281 kPreSerializedJSON = 4,
282 kNextBit = 5, 282 kNextBit = 5,
283 }; 283 };
284 284
285 class EventTypeField : public BitField<EventType, kEventTypeBit, 4> {}; 285 class EventTypeField : public BitField<uword, EventType, kEventTypeBit, 4> {};
286 class PreSerializedJSON : 286 class PreSerializedJSON :
287 public BitField<bool, kPreSerializedJSON, 1> {}; 287 public BitField<uword, bool, kPreSerializedJSON, 1> {};
288 288
289 int64_t timestamp0_; 289 int64_t timestamp0_;
290 int64_t timestamp1_; 290 int64_t timestamp1_;
291 TimelineEventArgument* arguments_; 291 TimelineEventArgument* arguments_;
292 intptr_t arguments_length_; 292 intptr_t arguments_length_;
293 uword state_; 293 uword state_;
294 const char* label_; 294 const char* label_;
295 const char* category_; 295 const char* category_;
296 ThreadId thread_; 296 ThreadId thread_;
297 Dart_Port isolate_id_; 297 Dart_Port isolate_id_;
(...skipping 447 matching lines...) Expand 10 before | Expand all | Expand 10 after
745 745
746 private: 746 private:
747 TimelineEventBlock* current_; 747 TimelineEventBlock* current_;
748 TimelineEventRecorder* recorder_; 748 TimelineEventRecorder* recorder_;
749 }; 749 };
750 750
751 751
752 } // namespace dart 752 } // namespace dart
753 753
754 #endif // VM_TIMELINE_H_ 754 #endif // VM_TIMELINE_H_
OLDNEW
« no previous file with comments | « runtime/vm/thread.h ('k') | tools/observatory_tool.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698