runtime/vm/bitfield_test.cc - Issue 1644223006: Fix some more shorten-64-to-32 warnings:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/bitfield_test.cc

Issue 1644223006: Fix some more shorten-64-to-32 warnings: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/bitfield_test.cc

diff --git a/runtime/vm/bitfield_test.cc b/runtime/vm/bitfield_test.cc

index 7728b29cb053e3ae91063ba69b19370ec60f7725..a9d41c9657a38ad260f705e78a2610d4fc752ffb 100644

--- a/runtime/vm/bitfield_test.cc

+++ b/runtime/vm/bitfield_test.cc

@@ -10,7 +10,7 @@

namespace dart {

UNIT_TEST_CASE(BitFields) {

- class TestBitFields : public BitField<int32_t, 1, 8> {};

+ class TestBitFields : public BitField<uword, int32_t, 1, 8> {};

EXPECT(TestBitFields::is_valid(16));

EXPECT(!TestBitFields::is_valid(256));

EXPECT_EQ(0x00ffU, TestBitFields::mask());

« no previous file with comments | « runtime/vm/bitfield.h ('k') | runtime/vm/class_table.h » ('j') | no next file with comments »