runtime/vm/timeline.h - Issue 1644223006: Fix some more shorten-64-to-32 warnings:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/timeline.h

Issue 1644223006: Fix some more shorten-64-to-32 warnings: (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address review comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/timeline.h

diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h

index ae714e5920c8e763eeae267f26ae6c6758e2d15b..a229acf90a366dd4505dcf86ab509a6feee9015e 100644

--- a/runtime/vm/timeline.h

+++ b/runtime/vm/timeline.h

@@ -282,9 +282,9 @@ class TimelineEvent {

kNextBit = 5,

};

- class EventTypeField : public BitField<EventType, kEventTypeBit, 4> {};

+ class EventTypeField : public BitField<uword, EventType, kEventTypeBit, 4> {};

class PreSerializedJSON :

- public BitField<bool, kPreSerializedJSON, 1> {};

+ public BitField<uword, bool, kPreSerializedJSON, 1> {};

int64_t timestamp0_;

int64_t timestamp1_;

« no previous file with comments | « runtime/vm/thread.h ('k') | tools/observatory_tool.py » ('j') | no next file with comments »