Issue 1642233002: [DevTools] Cleanup various bindInput implementations.

Issue 1642233002: [DevTools] Cleanup various bindInput implementations. (Closed)

Created:
4 years, 10 months ago by dgozman

Modified:
4 years, 10 months ago

Reviewers:
pfeldman

CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-misc

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

[DevTools] Cleanup various bindInput implementations. BUG=579949 Committed: https://crrev.com/138d5fe241b1a8542dc66932d5ab7400aac6151d Cr-Commit-Position: refs/heads/master@{#372291}

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+147 lines, -246 lines)			Patch
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js	View	4 chunks	+26 lines, -80 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/emulation/deviceModeToolbar.css	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js	View	2 chunks	+32 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js	View	2 chunks	+0 lines, -147 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/UIUtils.js	View	1 chunk	+77 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/inspectorStyle.css	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/devtools/front_end/ui/listWidget.css	View	1 chunk	+0 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 1641003003 Patch 1

Messages

Total messages: 10 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1642233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1642233002/1

4 years, 10 months ago (2016-01-29 02:36:51 UTC) #6

commit-bot: I haz the power

4 years, 10 months ago (2016-01-29 05:37:59 UTC) #10

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/138d5fe241b1a8542dc66932d5ab7400aac6151d
Cr-Commit-Position: refs/heads/master@{#372291}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages