Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js

Issue 1642233002: [DevTools] Cleanup various bindInput implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-misc
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
diff --git a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
index 189895342d4fcbc6ea8a412825eb1fa16e8668e0..a82c2352343ff9b731694220170525c98aa707cd 100644
--- a/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
+++ b/third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js
@@ -293,8 +293,7 @@ WebInspector.WorkspaceSettingsTab = function()
WebInspector.isolatedFileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded, this._fileSystemAdded, this);
WebInspector.isolatedFileSystemManager.addEventListener(WebInspector.IsolatedFileSystemManager.Events.FileSystemRemoved, this._fileSystemRemoved, this);
- var folderExcludeSetting = WebInspector.isolatedFileSystemManager.workspaceFolderExcludePatternSetting();
- var folderExcludePatternInput = WebInspector.SettingsUI.createSettingInputField(WebInspector.UIString("Folder exclude pattern"), folderExcludeSetting, false, 0, "270px", WebInspector.SettingsUI.regexValidator);
+ var folderExcludePatternInput = this._createFolderExcludePatternInput();
folderExcludePatternInput.classList.add("folder-exclude-pattern");
this.containerElement.appendChild(folderExcludePatternInput);
@@ -315,6 +314,37 @@ WebInspector.WorkspaceSettingsTab = function()
WebInspector.WorkspaceSettingsTab.prototype = {
/**
+ * @return {!Element}
+ */
+ _createFolderExcludePatternInput: function()
+ {
+ var p = createElement("p");
+ var labelElement = p.createChild("label");
+ labelElement.textContent = WebInspector.UIString("Folder exclude pattern");
+ var inputElement = p.createChild("input");
+ inputElement.type = "text";
+ inputElement.style.width = "270px";
+ var folderExcludeSetting = WebInspector.isolatedFileSystemManager.workspaceFolderExcludePatternSetting();
+ var setValue = WebInspector.bindInput(inputElement, folderExcludeSetting.set.bind(folderExcludeSetting), regexValidator, false);
+ folderExcludeSetting.addChangeListener(() => setValue.call(null, folderExcludeSetting.get()));
+ return p;
+
+ /**
+ * @param {string} value
+ * @return {boolean}
+ */
+ function regexValidator(value)
+ {
+ var regex;
+ try {
+ regex = new RegExp(value);
+ } catch (e) {
+ }
+ return !!regex;
+ }
+ },
+
+ /**
* @param {!WebInspector.IsolatedFileSystem} fileSystem
*/
_addItem: function(fileSystem)

Powered by Google App Engine
This is Rietveld 408576698