Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1641003003: [DevTools] Small cleanup after device mode v2. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-split
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Small cleanup after device mode v2. Removed Emulation.ViewportChanged event. Removed unnecessary methods from MediaQueryInspector. BUG=540864 Committed: https://crrev.com/ab81d6c319705c708cca4d6313a4cdd8f97b39d7 Cr-Commit-Position: refs/heads/master@{#372259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -122 lines) Patch
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeView.js View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/MediaQueryInspector.js View 8 chunks +5 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 2 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 3 chunks +0 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 3 chunks +0 lines, -36 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 2 chunks +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1641513003 Patch 1

Dependent Patchsets:

Issue 1642233002 Patch 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 10 months ago (2016-01-28 02:19:47 UTC) #2
pfeldman
lgtm
4 years, 10 months ago (2016-01-29 00:58:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1641003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1641003003/1
4 years, 10 months ago (2016-01-29 01:00:46 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-01-29 02:35:18 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-01-29 02:36:08 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ab81d6c319705c708cca4d6313a4cdd8f97b39d7
Cr-Commit-Position: refs/heads/master@{#372259}

Powered by Google App Engine
This is Rietveld 408576698