third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js - Issue 1642233002: [DevTools] Cleanup various bindInput implementations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

Issue 1642233002: [DevTools] Cleanup various bindInput implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-misc

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeToolbar.js ('k') | third_party/WebKit/Source/devtools/front_end/emulation/deviceModeToolbar.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

index 6e5bcd3d22dbacc3772c2d60ba25c7def667f666..44c1b8f5eb394bb806817e7ae3606eb39da9dadf 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/DevicesSettingsTab.js

@@ -221,7 +221,7 @@ WebInspector.DevicesSettingsTab.prototype = {

function sizeValidator(item, index, input)

{

- return !WebInspector.DeviceModeModel.deviceSizeValidator(input.value);

+ return WebInspector.DeviceModeModel.deviceSizeValidator(input.value);

}

/**

@@ -232,7 +232,7 @@ WebInspector.DevicesSettingsTab.prototype = {

function scaleValidator(item, index, input)

{

- return !WebInspector.DeviceModeModel.deviceScaleFactorValidator(input.value);

+ return WebInspector.DeviceModeModel.deviceScaleFactorValidator(input.value);

}

/**