Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js

Issue 1642233002: [DevTools] Cleanup various bindInput implementations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@device-mode-cleanup-misc
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js
diff --git a/third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js b/third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js
index 05c2a7ca8043324fef72119ff397c206f22cd7b6..5b35756227bc005ace945c4e6067fdde417c0650 100644
--- a/third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js
+++ b/third_party/WebKit/Source/devtools/front_end/ui/SettingsUI.js
@@ -78,139 +78,6 @@ WebInspector.SettingsUI.bindCheckbox = function(input, setting)
}
/**
- * @param {string} label
- * @param {!WebInspector.Setting} setting
- * @param {boolean} numeric
- * @param {number=} maxLength
- * @param {string=} width
- * @param {function(string):?string=} validatorCallback
- * @param {boolean=} instant
- * @param {boolean=} clearForZero
- * @param {string=} placeholder
- * @return {!Element}
- */
-WebInspector.SettingsUI.createSettingInputField = function(label, setting, numeric, maxLength, width, validatorCallback, instant, clearForZero, placeholder)
-{
- var p = createElement("p");
- var labelElement = p.createChild("label");
- labelElement.textContent = label;
- var inputElement = p.createChild("input");
- inputElement.type = "text";
- if (numeric)
- inputElement.className = "numeric";
- if (maxLength)
- inputElement.maxLength = maxLength;
- if (width)
- inputElement.style.width = width;
- inputElement.placeholder = placeholder || "";
-
- var errorMessageLabel;
- if (validatorCallback)
- errorMessageLabel = p.createChild("div", "field-error-message");
- WebInspector.SettingsUI.bindSettingInputField(inputElement, setting, numeric, validatorCallback, instant, clearForZero, errorMessageLabel);
- return p;
-}
-
-/**
- * @param {!Element} inputElement
- * @param {!WebInspector.Setting} setting
- * @param {boolean} numeric
- * @param {function(string):?string=} validatorCallback
- * @param {boolean=} instant
- * @param {boolean=} clearForZero
- * @param {!Element=} errorMessageLabel
- */
-WebInspector.SettingsUI.bindSettingInputField = function(inputElement, setting, numeric, validatorCallback, instant, clearForZero, errorMessageLabel)
-{
- if (validatorCallback || instant) {
- inputElement.addEventListener("change", onInput, false);
- inputElement.addEventListener("input", onInput, false);
- }
- inputElement.addEventListener("keydown", onKeyDown, false);
-
- function onInput()
- {
- if (validatorCallback)
- validate();
- if (instant)
- apply();
- }
-
- function onKeyDown(event)
- {
- if (isEnterKey(event))
- apply();
- incrementForArrows(event);
- }
-
- function incrementForArrows(event)
- {
- if (!numeric)
- return;
-
- var increment = event.keyIdentifier === "Up" ? 1 : event.keyIdentifier === "Down" ? -1 : 0;
- if (!increment)
- return;
- if (event.shiftKey)
- increment *= 10;
-
- var value = inputElement.value;
- if (validatorCallback && validatorCallback(value))
- return;
- value = Number(value);
- if (clearForZero && !value)
- return;
- value += increment;
- if (clearForZero && !value)
- return;
- value = String(value);
- if (validatorCallback && validatorCallback(value))
- return;
-
- inputElement.value = value;
- apply();
- event.preventDefault();
- }
-
- function validate()
- {
- var error = validatorCallback(inputElement.value);
- if (!error)
- error = "";
- inputElement.classList.toggle("error-input", !!error);
- if (errorMessageLabel)
- errorMessageLabel.textContent = error;
- }
-
- if (!instant)
- inputElement.addEventListener("blur", apply, false);
-
- function apply()
- {
- if (validatorCallback && validatorCallback(inputElement.value))
- return;
- setting.removeChangeListener(onSettingChange);
- setting.set(numeric ? Number(inputElement.value) : inputElement.value);
- setting.addChangeListener(onSettingChange);
- }
-
- setting.addChangeListener(onSettingChange);
-
- function onSettingChange()
- {
- var value = setting.get();
- if (clearForZero && !value)
- value = "";
- inputElement.value = value;
- validate();
- }
- onSettingChange();
-
- if (validatorCallback)
- validate();
-}
-
-/**
* @param {string} name
* @param {!Element} element
* @return {!Element}
@@ -242,20 +109,6 @@ WebInspector.SettingsUI.createSettingFieldset = function(setting)
}
/**
- * @param {string} text
- * @return {?string}
- */
-WebInspector.SettingsUI.regexValidator = function(text)
-{
- var regex;
- try {
- regex = new RegExp(text);
- } catch (e) {
- }
- return regex ? null : WebInspector.UIString("Invalid pattern");
-}
-
-/**
* Creates an input element under the parentElement with the given id and defaultText.
* @param {!Element} parentElement
* @param {string} id

Powered by Google App Engine
This is Rietveld 408576698