Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

This updates our copy of //base to be based off of commit 9659b08ea by
performing the following commands:

1.) Check out //base at 9659b08ea
2.) Apply the //base portion of the following commits from mojo:

57ca940d8410a27fdf517b6194d7ecb0f29ecc2a
c3b05c507e712f4ee65522e0a00e38c735c85244
d3482c6d25faabd04dffcea32d4dee18af74d600
18a6ce7215ece72e4359600852bb0cf5fd87339f
a67383613f17083d918c31cf377932f5b43b91ab
0204e1a3a6679a0e634b66f661e23f424f044152
d423877725e8606e5ebac142e5c4b5c8c2dc4810
7a690c5c0344946ed74402d61d473502bc03ad77
cfeba3cce284f8a4d382337201d479768bb0eb77
df7f866ce3da1ef3c212cde977a6a77dc832ce22
57be778fd4d820b026165969352d7b40d476730b
34776a703d8cce41052e5a3867a23d8970fbb549
0f5eacecbe12aae15b114a8511ae718506431b37
c4ebd590b6e2749a4ab3f97fd49bbd3a4d510759

3.) Fix up the rest of the repo for //base API changes:
  *) StartsWith/EndsWith string functions are in base:: namespace and have
  slightly different options
  *) Tokenize replaced with base::SplitString
  *) MessageLoopProxy removed, use TaskRunner instead

4.) git cl format, gn format
5.) Delete OWNERS file import from //base/mac to //chrome/...

This puts mojo's copy at base very close to parity with the flutter engine's
copy.

R=viettrungluu@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c4d0fb29b488b2e4d3a86361fa2409bd65ac9cb4

[jamesr, 2016-01-28 21:03:33]

jamesr@chromium.org changed reviewers:
+ abarth@chromium.org, viettrungluu@chromium.org

[jamesr, 2016-01-28 21:03:34]

Trung - can you take a look at the apps/, shell/, etc changes? Most are trivial.
//base itself is not changed other than our existing patches and formatting.

[viettrungluu, 2016-01-28 21:32:47]

https://codereview.chromium.org/1641513004/diff/1/gin/modules/console.cc
File gin/modules/console.cc (right):

https://codereview.chromium.org/1641513004/diff/1/gin/modules/console.cc#newc...
gin/modules/console.cc:28: std::cout << base::JoinString(messages,
base::StringPiece(" ")) << std::endl;
You don't need to include stringpiece.h? (Isn't there an implicit conversion?)

https://codereview.chromium.org/1641513004/diff/1/gin/per_isolate_data.h
File gin/per_isolate_data.h (right):

https://codereview.chromium.org/1641513004/diff/1/gin/per_isolate_data.h#newc...
gin/per_isolate_data.h:68: base::SingleThreadTaskRunner* message_loop_proxy() {
Do you want to rename the getter (and the member variable)?

https://codereview.chromium.org/1641513004/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/in_process_command_buffer.cc (right):

https://codereview.chromium.org/1641513004/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/in_process_command_buffer.cc:962: // thread
nit: Join this line with the next.

https://codereview.chromium.org/1641513004/diff/1/third_party/zlib/google/zip...
File third_party/zlib/google/zip_reader.cc (right):

https://codereview.chromium.org/1641513004/diff/1/third_party/zlib/google/zip...
third_party/zlib/google/zip_reader.cc:135:
base::CompareCase::INSENSITIVE_ASCII);
The case insensitivity seems kind of stupid here (and probably below in the
StartsWithASCII() too), no?

[jamesr, 2016-01-28 21:45:09]

PTAL

[viettrungluu, 2016-01-28 22:25:35]

lgtm

[jamesr, 2016-01-28 22:31:26]

Description was changed from

==========
Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

This updates our copy of //base to be based off of commit 9659b08ea by
performing the following commands:

1.) Check out //base at 9659b08ea
2.) Apply the //base portion of the following commits from mojo:

57ca940d8410a27fdf517b6194d7ecb0f29ecc2a
c3b05c507e712f4ee65522e0a00e38c735c85244
d3482c6d25faabd04dffcea32d4dee18af74d600
18a6ce7215ece72e4359600852bb0cf5fd87339f
a67383613f17083d918c31cf377932f5b43b91ab
0204e1a3a6679a0e634b66f661e23f424f044152
d423877725e8606e5ebac142e5c4b5c8c2dc4810
7a690c5c0344946ed74402d61d473502bc03ad77
cfeba3cce284f8a4d382337201d479768bb0eb77
df7f866ce3da1ef3c212cde977a6a77dc832ce22
57be778fd4d820b026165969352d7b40d476730b
34776a703d8cce41052e5a3867a23d8970fbb549
0f5eacecbe12aae15b114a8511ae718506431b37
c4ebd590b6e2749a4ab3f97fd49bbd3a4d510759

3.) Fix up the rest of the repo for //base API changes:
  *) StartsWith/EndsWith string functions are in base:: namespace and have
  slightly different options
  *) Tokenize replaced with base::SplitString
  *) MessageLoopProxy removed, use TaskRunner instead

4.) git cl format, gn format
5.) Delete OWNERS file import from //base/mac to //chrome/...

This puts mojo's copy at base very close to parity with the flutter engine's
copy.
==========

to

==========
Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

This updates our copy of //base to be based off of commit 9659b08ea by
performing the following commands:

1.) Check out //base at 9659b08ea
2.) Apply the //base portion of the following commits from mojo:

57ca940d8410a27fdf517b6194d7ecb0f29ecc2a
c3b05c507e712f4ee65522e0a00e38c735c85244
d3482c6d25faabd04dffcea32d4dee18af74d600
18a6ce7215ece72e4359600852bb0cf5fd87339f
a67383613f17083d918c31cf377932f5b43b91ab
0204e1a3a6679a0e634b66f661e23f424f044152
d423877725e8606e5ebac142e5c4b5c8c2dc4810
7a690c5c0344946ed74402d61d473502bc03ad77
cfeba3cce284f8a4d382337201d479768bb0eb77
df7f866ce3da1ef3c212cde977a6a77dc832ce22
57be778fd4d820b026165969352d7b40d476730b
34776a703d8cce41052e5a3867a23d8970fbb549
0f5eacecbe12aae15b114a8511ae718506431b37
c4ebd590b6e2749a4ab3f97fd49bbd3a4d510759

3.) Fix up the rest of the repo for //base API changes:
  *) StartsWith/EndsWith string functions are in base:: namespace and have
  slightly different options
  *) Tokenize replaced with base::SplitString
  *) MessageLoopProxy removed, use TaskRunner instead

4.) git cl format, gn format
5.) Delete OWNERS file import from //base/mac to //chrome/...

This puts mojo's copy at base very close to parity with the flutter engine's
copy.

R=viettrungluu@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/c4d0fb29b488b2e4d3a86361fa2...
==========

[jamesr, 2016-01-28 22:31:28]

Committed patchset #2 (id:10001) manually as
c4d0fb29b488b2e4d3a86361fa2409bd65ac9cb4.