Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1105)

Unified Diff: base/prefs/writeable_pref_store.h

Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2 (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/prefs/value_map_pref_store.cc ('k') | base/process/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/prefs/writeable_pref_store.h
diff --git a/base/prefs/writeable_pref_store.h b/base/prefs/writeable_pref_store.h
index d85b4c8d4272a054889e2b8eb3c9fe94292ec262..cde3c84d0f11f4140c2fcb59c5bfd159cab32d3e 100644
--- a/base/prefs/writeable_pref_store.h
+++ b/base/prefs/writeable_pref_store.h
@@ -8,6 +8,7 @@
#include <string>
#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
#include "base/prefs/pref_store.h"
namespace base {
@@ -30,10 +31,10 @@ class BASE_PREFS_EXPORT WriteablePrefStore : public PrefStore {
WriteablePrefStore() {}
- // Sets a |value| for |key| in the store. Assumes ownership of |value|, which
- // must be non-NULL. |flags| is a bitmask of PrefWriteFlags.
+ // Sets a |value| for |key| in the store. |value| must be non-NULL. |flags| is
+ // a bitmask of PrefWriteFlags.
virtual void SetValue(const std::string& key,
- base::Value* value,
+ scoped_ptr<base::Value> value,
uint32 flags) = 0;
// Removes the value for |key|.
@@ -56,7 +57,7 @@ class BASE_PREFS_EXPORT WriteablePrefStore : public PrefStore {
// tests rely on the number of notifications generated. |flags| is a bitmask
// of PrefWriteFlags.
virtual void SetValueSilently(const std::string& key,
- base::Value* value,
+ scoped_ptr<base::Value> value,
uint32 flags) = 0;
protected:
« no previous file with comments | « base/prefs/value_map_pref_store.cc ('k') | base/process/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698