shell/crash/crash_upload.cc - Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/crash/crash_upload.cc

Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/crash/crash_upload.cc

diff --git a/shell/crash/crash_upload.cc b/shell/crash/crash_upload.cc

index 17ecc5a2f9752bd32572717f74abb7b956505997..a2316c828c1f472dc222c47b740c0905f3611d9d 100644

--- a/shell/crash/crash_upload.cc

+++ b/shell/crash/crash_upload.cc

@@ -161,7 +161,7 @@ MinidumpAndBoundary GetMinidumpAndBoundary(const base::FilePath& dumps_path) {

// Find multipart boundary.

std::string start_of_file;

base::ReadFileToString(minidump, &start_of_file, kMaxBoundarySize);

- if (!StartsWithASCII(start_of_file, "--", true)) {

+ if (!base::StartsWith(start_of_file, "--", base::CompareCase::SENSITIVE)) {

LOG(WARNING) << "Corrupted minidump: " << minidump.value();

base::DeleteFile(minidump, false);

return MinidumpAndBoundary();

« no previous file with comments | « shell/context.cc ('k') | shell/filename_util.cc » ('j') | no next file with comments »