base/files/memory_mapped_file_unittest.cc - Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/files/memory_mapped_file_unittest.cc

Issue 1641513004: Update //base to chromium 9659b08ea5a34f889dc4166217f438095ddc10d2 (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/files/memory_mapped_file_unittest.cc

diff --git a/base/files/memory_mapped_file_unittest.cc b/base/files/memory_mapped_file_unittest.cc

index d0833b5cc9a24459857a356b5a7f013ca1ba8c49..05b941c308af2d8b3ae5e0d28e4e5e1425386acb 100644

--- a/base/files/memory_mapped_file_unittest.cc

+++ b/base/files/memory_mapped_file_unittest.cc

@@ -107,7 +107,8 @@ TEST_F(MemoryMappedFileTest, MapPartialRegionAtBeginning) {

MemoryMappedFile map;

File file(temp_file_path(), File::FLAG_OPEN | File::FLAG_READ);

- map.Initialize(file.Pass(), MemoryMappedFile::Region(0, kPartialSize));

+ MemoryMappedFile::Region region = {0, kPartialSize};

+ map.Initialize(file.Pass(), region);

ASSERT_EQ(kPartialSize, map.length());

ASSERT_TRUE(map.data() != NULL);

EXPECT_TRUE(map.IsValid());

@@ -122,7 +123,8 @@ TEST_F(MemoryMappedFileTest, MapPartialRegionAtEnd) {

MemoryMappedFile map;

File file(temp_file_path(), File::FLAG_OPEN | File::FLAG_READ);

- map.Initialize(file.Pass(), MemoryMappedFile::Region(kOffset, kPartialSize));

+ MemoryMappedFile::Region region = {kOffset, kPartialSize};

+ map.Initialize(file.Pass(), region);

ASSERT_EQ(kPartialSize, map.length());

ASSERT_TRUE(map.data() != NULL);

EXPECT_TRUE(map.IsValid());

@@ -138,7 +140,8 @@ TEST_F(MemoryMappedFileTest, MapSmallPartialRegionInTheMiddle) {

MemoryMappedFile map;

File file(temp_file_path(), File::FLAG_OPEN | File::FLAG_READ);

- map.Initialize(file.Pass(), MemoryMappedFile::Region(kOffset, kPartialSize));

+ MemoryMappedFile::Region region = {kOffset, kPartialSize};

+ map.Initialize(file.Pass(), region);

ASSERT_EQ(kPartialSize, map.length());

ASSERT_TRUE(map.data() != NULL);

EXPECT_TRUE(map.IsValid());

@@ -154,7 +157,8 @@ TEST_F(MemoryMappedFileTest, MapLargePartialRegionInTheMiddle) {

MemoryMappedFile map;

File file(temp_file_path(), File::FLAG_OPEN | File::FLAG_READ);

- map.Initialize(file.Pass(), MemoryMappedFile::Region(kOffset, kPartialSize));

+ MemoryMappedFile::Region region = {kOffset, kPartialSize};

+ map.Initialize(file.Pass(), region);

ASSERT_EQ(kPartialSize, map.length());

ASSERT_TRUE(map.data() != NULL);

EXPECT_TRUE(map.IsValid());

« no previous file with comments | « base/files/memory_mapped_file.cc ('k') | base/files/memory_mapped_file_win.cc » ('j') | no next file with comments »