Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 162613007: Reduce the number of parameters to LayoutStateMaintainer by one (Closed)

Created:
6 years, 10 months ago by atreat
Modified:
6 years, 10 months ago
Reviewers:
pdr., eseidel, rwlbuis
CC:
blink-reviews, mstensho+blink_opera.com, jfernandez, philipj_slow, bemjb+rendering_chromium.org, dsinclair, Manuel Rego, zoltan1, eae+blinkwatch, leviw+renderwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, svillar
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reduce the number of parameters to LayoutStateMaintainer by one Reduce the number of parameters to LayoutStateMaintainer by one. I'm trying to find ways to clean up some of the long parameter lists we have for various methods in the render tree. This is one such attempt. BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M Source/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderEmbeddedObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMedia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableRow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTableSection.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderVTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderView.h View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
atreat
6 years, 10 months ago (2014-02-19 17:57:56 UTC) #1
eseidel
lgtm
6 years, 10 months ago (2014-02-19 18:28:18 UTC) #2
pdr.
On 2014/02/19 17:57:56, atreat wrote: I like. LGTM
6 years, 10 months ago (2014-02-19 18:29:36 UTC) #3
rwlbuis
On 2014/02/19 18:29:36, pdr wrote: > On 2014/02/19 17:57:56, atreat wrote: > > I like. ...
6 years, 10 months ago (2014-02-19 18:47:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/162613007/1
6 years, 10 months ago (2014-02-19 22:00:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/162613007/1
6 years, 10 months ago (2014-02-19 23:06:27 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-20 07:22:14 UTC) #7
Message was sent while issue was closed. 
Change committed as 167467

Powered by Google App Engine
This is Rietveld 408576698