Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Side by Side Diff: Source/core/rendering/RenderTableRow.cpp

Issue 162613007: Reduce the number of parameters to LayoutStateMaintainer by one (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /** 1 /**
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 section()->setNeedsCellRecalc(); 156 section()->setNeedsCellRecalc();
157 } 157 }
158 158
159 void RenderTableRow::layout() 159 void RenderTableRow::layout()
160 { 160 {
161 ASSERT(needsLayout()); 161 ASSERT(needsLayout());
162 162
163 LayoutRectRecorder recorder(*this); 163 LayoutRectRecorder recorder(*this);
164 164
165 // Table rows do not add translation. 165 // Table rows do not add translation.
166 LayoutStateMaintainer statePusher(view(), this, LayoutSize(), style()->isFli ppedBlocksWritingMode()); 166 LayoutStateMaintainer statePusher(this, LayoutSize(), style()->isFlippedBloc ksWritingMode());
167 167
168 bool paginated = view()->layoutState()->isPaginated(); 168 bool paginated = view()->layoutState()->isPaginated();
169 169
170 for (RenderObject* child = firstChild(); child; child = child->nextSibling() ) { 170 for (RenderObject* child = firstChild(); child; child = child->nextSibling() ) {
171 if (child->isTableCell()) { 171 if (child->isTableCell()) {
172 SubtreeLayoutScope layouter(child); 172 SubtreeLayoutScope layouter(child);
173 RenderTableCell* cell = toRenderTableCell(child); 173 RenderTableCell* cell = toRenderTableCell(child);
174 if (!cell->needsLayout() && paginated && view()->layoutState()->page LogicalHeight() && view()->layoutState()->pageLogicalOffset(cell, cell->logicalT op()) != cell->pageLogicalOffset()) 174 if (!cell->needsLayout() && paginated && view()->layoutState()->page LogicalHeight() && view()->layoutState()->pageLogicalOffset(cell, cell->logicalT op()) != cell->pageLogicalOffset())
175 layouter.setChildNeedsLayout(cell); 175 layouter.setChildNeedsLayout(cell);
176 176
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
285 285
286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent) 286 RenderTableRow* RenderTableRow::createAnonymousWithParentRenderer(const RenderOb ject* parent)
287 { 287 {
288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() ); 288 RenderTableRow* newRow = RenderTableRow::createAnonymous(&parent->document() );
289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW); 289 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_ROW);
290 newRow->setStyle(newStyle.release()); 290 newRow->setStyle(newStyle.release());
291 return newRow; 291 return newRow;
292 } 292 }
293 293
294 } // namespace WebCore 294 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698