[SVG] Paint unnormalized paths

[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com

Committed: https://crrev.com/7003bed16de3861e47d6bb0287ba4d6bffcfea04
Cr-Commit-Position: refs/heads/master@{#371345}

[f(malita), 2016-01-24 17:54:30]

Description was changed from

==========
[SVG] Unnormalized path painting

WIP

BUG=
==========

to

==========
[SVG] Unnormalized path painting

WIP

BUG=453040
==========

[f(malita), 2016-01-25 17:31:37]

Description was changed from

==========
[SVG] Unnormalized path painting

WIP

BUG=453040
==========

to

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
==========

[f(malita), 2016-01-25 17:58:14]

Description was changed from

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
==========

to

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com
==========

[f(malita), 2016-01-25 17:58:14]

fmalita@chromium.org changed reviewers:
+ caryclark@google.com, fs@opera.com

[f(malita), 2016-01-25 18:31:52]

21 trivial rebaselines:
https://storage.googleapis.com/chromium-layout-test-archives/mac_chromium_rel...

[caryclark, 2016-01-25 19:00:58]

(to the extent that I understand it) lgtm

[fs, 2016-01-25 19:17:40]

LGTM w/ nits

I guess the DRT (txt) changes are because we no longer pass Skia cubics, so we
get better/worse (==different) bounds?

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:30: FloatPoint
SVGPathBuilder::smoothControl(bool isSmooth) const
isSmooth -> isCompatibleSegment or something? (To avoid confusing different
meanings of "smooth" in this context.)

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:83: bool isSmooth =
m_lastCommand == PathSegCurveToQuadraticAbs
isSmooth -> isQuadratic/lastWasQuadratic per above.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:100: bool isSmooth =
m_lastCommand == PathSegCurveToCubicAbs
Analogue to the quad case.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathBuilder.h (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.h:61: FloatPoint
m_initialPoint;
I recently asked for something similar to this to be called m_subPathPoint, so I
guess I can't flinch now ;-)

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp:39: return
parser.parsePathDataFromSource(UnalteredParsing);
I think means that the PathParsingMode is now dead! (yay!?) Someone(TM) should
clean that up...

[f(malita), 2016-01-25 19:37:06]

On 2016/01/25 19:17:40, fs wrote:
> I guess the DRT (txt) changes are because we no longer pass Skia cubics, so we
> get better/worse (==different) bounds?

Yup: different representation => different control points + bounds are
currently/unfortunately control point-based.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:30: FloatPoint
SVGPathBuilder::smoothControl(bool isSmooth) const
On 2016/01/25 19:17:40, fs wrote:
> isSmooth -> isCompatibleSegment or something? (To avoid confusing different
> meanings of "smooth" in this context.)

Done.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:83: bool isSmooth =
m_lastCommand == PathSegCurveToQuadraticAbs
On 2016/01/25 19:17:40, fs wrote:
> isSmooth -> isQuadratic/lastWasQuadratic per above.

Done.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.cpp:100: bool isSmooth =
m_lastCommand == PathSegCurveToCubicAbs
On 2016/01/25 19:17:40, fs wrote:
> Analogue to the quad case.

Done.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathBuilder.h (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathBuilder.h:61: FloatPoint
m_initialPoint;
On 2016/01/25 19:17:40, fs wrote:
> I recently asked for something similar to this to be called m_subPathPoint, so
I
> guess I can't flinch now ;-)

Done.

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp (right):

https://codereview.chromium.org/1623073003/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/svg/SVGPathUtilities.cpp:39: return
parser.parsePathDataFromSource(UnalteredParsing);
On 2016/01/25 19:17:40, fs wrote:
> I think means that the PathParsingMode is now dead! (yay!?) Someone(TM) should
> clean that up...

Yup, I was just wondering about that :)  Should be a fun cleanup CL.

[f(malita), 2016-01-25 20:11:18]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-01-25 20:11:18]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com,
caryclark@google.com
Link to the patchset: https://codereview.chromium.org/1623073003/#ps100001
(title: "missed review comments")

[commit-bot: I haz the power, 2016-01-25 20:16:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1623073003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1623073003/100001

[commit-bot: I haz the power, 2016-01-25 22:07:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:07:20]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[f(malita), 2016-01-25 22:19:06]

The CQ bit was checked by fmalita@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:21:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1623073003/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1623073003/100001

[commit-bot: I haz the power, 2016-01-25 23:16:55]

Description was changed from

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com
==========

to

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com
==========

[commit-bot: I haz the power, 2016-01-25 23:16:56]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-01-25 23:17:37]

Description was changed from

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com
==========

to

==========
[SVG] Paint unnormalized paths

The SkPath API supports all SVG path verbs, so there's no need to
normalize paths when converting to the Skia representation.

Switch buildPathFromString() and buildPathFromByteStream() to unaltered
parsing, and expand SVGPathBuilder to handle the full path vocabulary.

This yields a more natural verb conversion (arcTo, in particular, is no
longer decomposed into cubics), with correctness and perf implications.

BUG=453040
R=fs@opera.com,caryclark@google.com

Committed: https://crrev.com/7003bed16de3861e47d6bb0287ba4d6bffcfea04
Cr-Commit-Position: refs/heads/master@{#371345}
==========

[commit-bot: I haz the power, 2016-01-25 23:17:39]

Patchset 6 (id:??) landed as
https://crrev.com/7003bed16de3861e47d6bb0287ba4d6bffcfea04
Cr-Commit-Position: refs/heads/master@{#371345}