third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h - Issue 1623073003: [SVG] Paint unnormalized paths

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

Issue 1623073003: [SVG] Paint unnormalized paths (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed review comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h b/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

index 3c646e40143227f0aa0af77b1a16ea9594e8e121..0a8734bc6820a104096f51b63836797dfcd82ec9 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

+++ b/third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h

@@ -137,7 +137,8 @@ private:

switch (element->type) {

case PathElementAddQuadCurveToPoint:

- // FIXME: https://bugs.webkit.org/show_bug.cgi?id=33115 (PathElementAddQuadCurveToPoint not handled for <marker>)

+ m_inslopePoints[0] = points[0];

+ m_inslopePoints[1] = points[1];

m_origin = points[1];

break;

case PathElementAddCurveToPoint: