Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. (Closed)

Created:
4 years, 11 months ago by pfeldman
Modified:
4 years, 11 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. BUG=580337 Committed: https://crrev.com/6ce02b6ce1269c206f8d902abb1571b39e773e7e Cr-Commit-Position: refs/heads/master@{#371071}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -80 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h View 1 chunk +7 lines, -24 lines 0 comments Download
A third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.cpp View 1 1 chunk +49 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/InspectorWrapper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8Debugger.h View 1 2 2 chunks +0 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h View 1 chunk +1 line, -0 lines 1 comment Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.cpp View 5 chunks +14 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerClient.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8DebuggerImpl.h View 1 2 4 chunks +16 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
pfeldman
4 years, 11 months ago (2016-01-22 00:03:11 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1618003003/diff/40001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h (right): https://codereview.chromium.org/1618003003/diff/40001/third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h#newcode97 third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h:97: virtual V8Debugger& debugger() = 0; I think this ...
4 years, 11 months ago (2016-01-22 18:24:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1618003003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1618003003/40001
4 years, 11 months ago (2016-01-22 21:37:19 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-22 23:14:01 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 23:15:17 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/6ce02b6ce1269c206f8d902abb1571b39e773e7e
Cr-Commit-Position: refs/heads/master@{#371071}

Powered by Google App Engine
This is Rietveld 408576698