Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp

Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp b/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
index 2602bc67a27a5c083717f95fa54920d82e89523c..9c0b6e7845e7f6cf8a1df6ba7095365c6b51192a 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8InjectedScriptHost.cpp
@@ -174,7 +174,7 @@ void V8InjectedScriptHost::functionDetailsCallback(const v8::FunctionCallbackInf
result->Set(v8AtomicString(isolate, "isGenerator"), v8::Boolean::New(isolate, function->IsGeneratorFunction()));
InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- V8Debugger& debugger = host->debugger();
+ V8DebuggerImpl& debugger = static_cast<V8DebuggerImpl&>(host->debugger());
v8::MaybeLocal<v8::Value> scopes = debugger.functionScopes(function);
if (!scopes.IsEmpty() && scopes.ToLocalChecked()->IsArray())
result->Set(v8AtomicString(isolate, "rawScopes"), scopes.ToLocalChecked());
@@ -190,7 +190,7 @@ void V8InjectedScriptHost::generatorObjectDetailsCallback(const v8::FunctionCall
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(info[0]);
InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- V8Debugger& debugger = host->debugger();
+ V8DebuggerImpl& debugger = static_cast<V8DebuggerImpl&>(host->debugger());
v8SetReturnValue(info, debugger.generatorObjectDetails(object));
}
@@ -202,7 +202,7 @@ void V8InjectedScriptHost::collectionEntriesCallback(const v8::FunctionCallbackI
v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(info[0]);
InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- V8Debugger& debugger = host->debugger();
+ V8DebuggerImpl& debugger = static_cast<V8DebuggerImpl&>(host->debugger());
v8SetReturnValue(info, debugger.collectionEntries(object));
}
@@ -345,7 +345,7 @@ void V8InjectedScriptHost::setFunctionVariableValueCallback(const v8::FunctionCa
v8::Local<v8::Value> newValue = info[3];
InjectedScriptHost* host = V8InjectedScriptHost::unwrap(info.GetIsolate()->GetCurrentContext(), info.Holder());
- V8Debugger& debugger = host->debugger();
+ V8DebuggerImpl& debugger = static_cast<V8DebuggerImpl&>(host->debugger());
v8SetReturnValue(info, debugger.setFunctionVariableValue(functionValue, scopeIndex, variableName, newValue));
}

Powered by Google App Engine
This is Rietveld 408576698