Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8Debugger.h

Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8Debugger.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/V8Debugger.h b/third_party/WebKit/Source/core/inspector/v8/V8Debugger.h
index 7bf72f227379bcd34d0498b974b30e39e9746af6..bab92bb47c33931c7121fdb2f1ed8d8aa7f98406 100644
--- a/third_party/WebKit/Source/core/inspector/v8/V8Debugger.h
+++ b/third_party/WebKit/Source/core/inspector/v8/V8Debugger.h
@@ -6,19 +6,14 @@
#define V8Debugger_h
#include "core/CoreExport.h"
-#include "core/InspectorTypeBuilder.h"
-#include "wtf/Allocator.h"
#include "wtf/Forward.h"
#include "wtf/PassOwnPtr.h"
-#include <v8-debug.h>
#include <v8.h>
namespace blink {
-class JavaScriptCallFrame;
class V8DebuggerClient;
-struct ScriptBreakpoint;
class CORE_EXPORT V8Debugger {
USING_FAST_MALLOC(V8Debugger);
@@ -26,32 +21,11 @@ public:
static PassOwnPtr<V8Debugger> create(v8::Isolate*, V8DebuggerClient*);
virtual ~V8Debugger() { }
- virtual bool enabled() const = 0;
-
// Each v8::Context is a part of a group. The group id is used to find approapriate
// V8DebuggerAgent to notify about events in the context.
// |contextGroupId| must be non-0.
static void setContextDebugData(v8::Local<v8::Context>, const String& type, int contextGroupId);
-
static int contextId(v8::Local<v8::Context>);
-
- enum PauseOnExceptionsState {
- DontPauseOnExceptions,
- PauseOnAllExceptions,
- PauseOnUncaughtExceptions
- };
- virtual PauseOnExceptionsState pauseOnExceptionsState() = 0;
- virtual void setPauseOnExceptionsState(PauseOnExceptionsState) = 0;
-
- // TODO: remove these methods once runtime agent is part of the implementation.
- virtual void setPauseOnNextStatement(bool) = 0;
- virtual bool pausingOnNextStatement() = 0;
-
- // TODO: these methods will not be public once InjectedScriptHost is in the implementation.
- virtual v8::MaybeLocal<v8::Value> functionScopes(v8::Local<v8::Function>) = 0;
- virtual v8::Local<v8::Value> generatorObjectDetails(v8::Local<v8::Object>&) = 0;
- virtual v8::Local<v8::Value> collectionEntries(v8::Local<v8::Object>&) = 0;
- virtual v8::MaybeLocal<v8::Value> setFunctionVariableValue(v8::Local<v8::Value> functionValue, int scopeNumber, const String& variableName, v8::Local<v8::Value> newValue) = 0;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698