Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h

Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h
diff --git a/third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h b/third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h
index 2319930b73a1e30bb61c4ea589956503be4e1b8e..f46b133a497df3c2f5532f047c4241365cdfb6a3 100644
--- a/third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h
+++ b/third_party/WebKit/Source/core/inspector/v8/IgnoreExceptionsScope.h
@@ -5,37 +5,20 @@
#ifndef IgnoreExceptionsScope_h
#define IgnoreExceptionsScope_h
-#include "core/inspector/v8/V8DebuggerImpl.h"
+#include "wtf/OwnPtr.h"
namespace blink {
+class V8Debugger;
+class IgnoreExceptionsScopeImpl;
+
class IgnoreExceptionsScope {
public:
- explicit IgnoreExceptionsScope(V8DebuggerImpl* debugger)
- : m_debugger(debugger)
- , m_previousPauseOnExceptionsState(V8Debugger::DontPauseOnExceptions)
- {
- m_previousPauseOnExceptionsState = setPauseOnExceptionsState(V8Debugger::DontPauseOnExceptions);
- }
- ~IgnoreExceptionsScope()
- {
- setPauseOnExceptionsState(m_previousPauseOnExceptionsState);
- }
+ explicit IgnoreExceptionsScope(V8Debugger*);
+ ~IgnoreExceptionsScope();
private:
- V8Debugger::PauseOnExceptionsState setPauseOnExceptionsState(V8Debugger::PauseOnExceptionsState newState)
- {
- ASSERT(m_debugger);
- if (!m_debugger->enabled())
- return newState;
- V8Debugger::PauseOnExceptionsState presentState = m_debugger->pauseOnExceptionsState();
- if (presentState != newState)
- m_debugger->setPauseOnExceptionsState(newState);
- return presentState;
- }
-
- V8DebuggerImpl* m_debugger;
- V8Debugger::PauseOnExceptionsState m_previousPauseOnExceptionsState;
+ OwnPtr<IgnoreExceptionsScopeImpl> m_impl;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698