third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp - Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

Issue 1618003003: DevTools: clean up V8Debugger.h API, remove parts accessed only from within inspector/v8. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/core.gypi ('k') | third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp » ('j') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

index d62ef9b07208e07864aef3db28757c3d5b2ab750..de46f84c29315839db5b7a90e4b778529ab1e647 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorConsoleAgent.cpp

@@ -108,8 +108,7 @@ void InspectorConsoleAgent::addMessageToConsole(ConsoleMessage* consoleMessage)

return;

if (!m_debuggerAgent || !m_debuggerAgent->enabled())

return;

- if (m_debuggerAgent->debugger().pauseOnExceptionsState() != V8Debugger::DontPauseOnExceptions)

- m_debuggerAgent->breakProgram(InspectorFrontend::Debugger::Reason::Assert, nullptr);

+ m_debuggerAgent->breakProgramOnException(InspectorFrontend::Debugger::Reason::Assert, nullptr);

}

void InspectorConsoleAgent::clearAllMessages()