Fix remaining incompatibilities between scoped_ptr and unique_ptr.

Fix remaining incompatibilities between scoped_ptr and unique_ptr.

scoped_ptr is more convertible to bool than std::unique_ptr.
  bool x = scoped_ptr<int>();  // compiles
  bool y = std::unique_ptr<int>();  // explodes

std::unique_ptr is not streamable:
  LOG(ERROR) << scoped_ptr<int>();  // compiles
  LOG(ERROR) << std::unique_ptr<int>();  // explodes

BUG=579269, 579270
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5d64b5269aa9293c992f41235290366d21cb38ac
Cr-Commit-Position: refs/heads/master@{#370266}

[dcheng, 2016-01-19 23:40:01]

Description was changed from

==========
Fix remaining incompatibilities between scoped_ptr and unique_ptr.

scoped_ptr is more convertible to bool than std::unique_ptr.
  bool x = scoped_ptr<int>();  // compiles
  bool y = std::unique_ptr<int>();  // explodes

std::unique_ptr is not streamable:
  LOG(ERROR) << scoped_ptr<int>();  // compiles
  LOG(ERROR) << std::unique_ptr<int>();  // explodes

BUG=579269,579270
==========

to

==========
Fix remaining incompatibilities between scoped_ptr and unique_ptr.

scoped_ptr is more convertible to bool than std::unique_ptr.
  bool x = scoped_ptr<int>();  // compiles
  bool y = std::unique_ptr<int>();  // explodes

std::unique_ptr is not streamable:
  LOG(ERROR) << scoped_ptr<int>();  // compiles
  LOG(ERROR) << std::unique_ptr<int>();  // explodes

BUG=579269,579270
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[dcheng, 2016-01-19 23:42:45]

dcheng@chromium.org changed reviewers:
+ brettw@chromium.org

[dcheng, 2016-01-19 23:42:46]

Brett, mind reviewing this? Pretty straightforward change.

Places that use a scoped_ptr as a bool now use !! to force the explicit bool
conversion.
Places that tried to log a scoped_ptr now call .get() explicitly.

I haven't changed scoped_ptr.h itself because it seems like more effort than
it's worth: there are undoubtedly a few more instances in platform specific
code, but we're very close to having the codebase compile with scoped_ptr as a
typedef for std::unique_ptr. Switching to the typedef, that will enforce the
behavior changes in this CL.

[dcheng, 2016-01-19 23:42:55]

The CQ bit was checked by dcheng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-19 23:44:16]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609923002/1

[brettw, 2016-01-19 23:47:56]

lgtm

[dcheng, 2016-01-19 23:50:55]

(Forgot to send the draft comments, so two comments on things that I noticed
when making these changes. The //sync thing seems like a separate cleanup)

https://codereview.chromium.org/1609923002/diff/1/media/base/bind_to_current_...
File media/base/bind_to_current_loop_unittest.cc (right):

https://codereview.chromium.org/1609923002/diff/1/media/base/bind_to_current_...
media/base/bind_to_current_loop_unittest.cc:26: *var = *val;
Note: I changed this to deref the value of the scoped_ptr, since that /appears/
to be the intent of the tests. The helpers surrounding this all appear to do
that.

https://codereview.chromium.org/1609923002/diff/1/sync/engine/non_blocking_ty...
File sync/engine/non_blocking_type_commit_contribution.cc (right):

https://codereview.chromium.org/1609923002/diff/1/sync/engine/non_blocking_ty...
sync/engine/non_blocking_type_commit_contribution.cc:65: <<
syncer::SyncEntityToValue(entities_.Get(i), false).get();
This seems pretty silly: we log out a pointer value that's going to be
immediately deleted...

[danakj, 2016-01-19 23:59:34]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2016-01-19 23:59:34]

LGTM 2

[commit-bot: I haz the power, 2016-01-20 01:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:19:43]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-01-20 01:22:06]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:23:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1609923002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1609923002/1

[commit-bot: I haz the power, 2016-01-20 01:41:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-20 01:43:25]

Description was changed from

==========
Fix remaining incompatibilities between scoped_ptr and unique_ptr.

scoped_ptr is more convertible to bool than std::unique_ptr.
  bool x = scoped_ptr<int>();  // compiles
  bool y = std::unique_ptr<int>();  // explodes

std::unique_ptr is not streamable:
  LOG(ERROR) << scoped_ptr<int>();  // compiles
  LOG(ERROR) << std::unique_ptr<int>();  // explodes

BUG=579269,579270
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Fix remaining incompatibilities between scoped_ptr and unique_ptr.

scoped_ptr is more convertible to bool than std::unique_ptr.
  bool x = scoped_ptr<int>();  // compiles
  bool y = std::unique_ptr<int>();  // explodes

std::unique_ptr is not streamable:
  LOG(ERROR) << scoped_ptr<int>();  // compiles
  LOG(ERROR) << std::unique_ptr<int>();  // explodes

BUG=579269,579270
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/5d64b5269aa9293c992f41235290366d21cb38ac
Cr-Commit-Position: refs/heads/master@{#370266}
==========

[commit-bot: I haz the power, 2016-01-20 01:43:26]

Patchset 1 (id:??) landed as
https://crrev.com/5d64b5269aa9293c992f41235290366d21cb38ac
Cr-Commit-Position: refs/heads/master@{#370266}