sync/internal_api/public/util/proto_value_ptr_unittest.cc - Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/util/proto_value_ptr_unittest.cc

Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/engine/non_blocking_type_commit_contribution.cc ('K') | « sync/engine/non_blocking_type_commit_contribution.cc ('k') | sync/sessions/data_type_tracker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/util/proto_value_ptr_unittest.cc

diff --git a/sync/internal_api/public/util/proto_value_ptr_unittest.cc b/sync/internal_api/public/util/proto_value_ptr_unittest.cc

index f439825f5cfbd8e1404c47cf0e123099d36d163e..142098048e54ee4d58a174113af8754fc50a4315 100644

--- a/sync/internal_api/public/util/proto_value_ptr_unittest.cc

+++ b/sync/internal_api/public/util/proto_value_ptr_unittest.cc

@@ -45,7 +45,7 @@ class TestValue {

int value() const { return value_->value(); }

IntValue* value_ptr() const { return value_.get(); }

- bool is_initialized() const { return value_; }

+ bool is_initialized() const { return !!value_; }

bool is_default() const { return is_default_; }

// TestValue uses the default traits struct with ProtoValuePtr<TestValue>.