chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc - Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profile_resetter/brandcode_config_fetcher.h ('k') | chrome/browser/ssl/common_name_mismatch_handler.cc » ('j') | media/base/bind_to_current_loop_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

diff --git a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

index cac45384d549761026e78b228b068b0e5007bfcd..4a449b1239eb4f1b9b3dd2008510c370d0e819bc 100644

--- a/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

+++ b/chrome/browser/signin/easy_unlock_screenlock_state_handler_unittest.cc

@@ -139,9 +139,7 @@ class TestLockHandler : public proximity_auth::ScreenlockBridge::LockHandler {

}

// Whether the custom icon is set.

- bool HasCustomIcon() const {

- return last_custom_icon_;

- }

+ bool HasCustomIcon() const { return !!last_custom_icon_; }

// If custom icon is set, returns the icon's id.

// If there is no icon, or if it doesn't have an id set, returns an empty