ui/views/controls/combobox/combobox.cc - Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/combobox/combobox.cc

Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/engine/non_blocking_type_commit_contribution.cc ('K') | « ui/keyboard/keyboard_controller_unittest.cc ('k') | ui/views/controls/native/native_view_host_aura.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/views/controls/combobox/combobox.cc

diff --git a/ui/views/controls/combobox/combobox.cc b/ui/views/controls/combobox/combobox.cc

index fa957ef61d42ff3e56837a359519e39d0f0516ae..22512ea926c9607c8e663079041c636440412420 100644

--- a/ui/views/controls/combobox/combobox.cc

+++ b/ui/views/controls/combobox/combobox.cc

@@ -528,7 +528,7 @@ bool Combobox::SkipDefaultKeyEventProcessing(const ui::KeyEvent& e) {

e.IsShiftDown() || e.IsControlDown() || e.IsAltDown()) {

return false;

}

- return menu_runner_;

+ return !!menu_runner_;

}

bool Combobox::OnKeyPressed(const ui::KeyEvent& e) {