Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Side by Side Diff: net/test/cert_test_util_nss.cc

Issue 1609923002: Fix remaining incompatibilities between scoped_ptr and unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/test/cert_test_util.h" 5 #include "net/test/cert_test_util.h"
6 6
7 #include <pk11pub.h> 7 #include <pk11pub.h>
8 #include <secmodt.h> 8 #include <secmodt.h>
9 9
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 19 matching lines...) Expand all
30 const uint8_t* key_pkcs8_begin = 30 const uint8_t* key_pkcs8_begin =
31 reinterpret_cast<const uint8_t*>(key_pkcs8.data()); 31 reinterpret_cast<const uint8_t*>(key_pkcs8.data());
32 std::vector<uint8_t> key_vector(key_pkcs8_begin, 32 std::vector<uint8_t> key_vector(key_pkcs8_begin,
33 key_pkcs8_begin + key_pkcs8.length()); 33 key_pkcs8_begin + key_pkcs8.length());
34 34
35 crypto::ScopedSECKEYPrivateKey private_key( 35 crypto::ScopedSECKEYPrivateKey private_key(
36 crypto::ImportNSSKeyFromPrivateKeyInfo(slot, key_vector, 36 crypto::ImportNSSKeyFromPrivateKeyInfo(slot, key_vector,
37 true /* permanent */)); 37 true /* permanent */));
38 LOG_IF(ERROR, !private_key) << "Could not create key from file " 38 LOG_IF(ERROR, !private_key) << "Could not create key from file "
39 << key_path.value(); 39 << key_path.value();
40 return private_key; 40 return !!private_key;
41 } 41 }
42 42
43 bool ImportClientCertToSlot(const scoped_refptr<X509Certificate>& cert, 43 bool ImportClientCertToSlot(const scoped_refptr<X509Certificate>& cert,
44 PK11SlotInfo* slot) { 44 PK11SlotInfo* slot) {
45 std::string nickname = cert->GetDefaultNickname(USER_CERT); 45 std::string nickname = cert->GetDefaultNickname(USER_CERT);
46 { 46 {
47 crypto::AutoNSSWriteLock lock; 47 crypto::AutoNSSWriteLock lock;
48 SECStatus rv = PK11_ImportCert(slot, 48 SECStatus rv = PK11_ImportCert(slot,
49 cert->os_cert_handle(), 49 cert->os_cert_handle(),
50 CK_INVALID_HANDLE, 50 CK_INVALID_HANDLE,
(...skipping 27 matching lines...) Expand all
78 if (!ImportClientCertToSlot(cert, slot)) 78 if (!ImportClientCertToSlot(cert, slot))
79 return NULL; 79 return NULL;
80 80
81 // |cert| continues to point to the original X509Certificate before the 81 // |cert| continues to point to the original X509Certificate before the
82 // import to |slot|. However this should not make a difference as NSS handles 82 // import to |slot|. However this should not make a difference as NSS handles
83 // state globally. 83 // state globally.
84 return cert; 84 return cert;
85 } 85 }
86 86
87 } // namespace net 87 } // namespace net
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698