Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(762)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1608053002: Remove now-unnecessary wrappers around gfx::Screen::GetScreen() (Closed)

Created:
4 years, 11 months ago by scottmg
Modified:
4 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, sadrul, jam, tdanderson+overview_chromium.org, dcheng, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@metro-mode-5
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now-unnecessary wrappers around gfx::Screen::GetScreen() - ash::Shell::GetScreen() - DisplayInfoProvider::GetActiveScreen() Followup to https://codereview.chromium.org/1608733002/. R=oshima@chromium.org, sky@chromium.org BUG=558054 Committed: https://crrev.com/e8b0429751298d4bff935658ad0501597bedfb54 Cr-Commit-Position: refs/heads/master@{#371733}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 18

Patch Set 3 : fixes and rebase #

Patch Set 4 : cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+588 lines, -513 lines) Patch
M ash/accelerators/accelerator_controller.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/content/keyboard_overlay/keyboard_overlay_delegate_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ash/desktop_background/desktop_background_view.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/dip_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/cursor_window_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/display/cursor_window_controller_unittest.cc View 1 2 3 1 chunk +7 lines, -5 lines 0 comments Download
M ash/display/display_manager_unittest.cc View 1 2 3 26 chunks +52 lines, -41 lines 0 comments Download
M ash/display/event_transformation_handler.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ash/display/extended_mouse_warp_controller.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/display/mirror_window_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/display/resolution_notification_controller.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M ash/display/resolution_notification_controller_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M ash/display/root_window_transformers.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/display/root_window_transformers_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M ash/display/screen_ash.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M ash/display/screen_ash_unittest.cc View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M ash/display/screen_position_controller.cc View 3 chunks +14 lines, -6 lines 0 comments Download
M ash/display/screen_position_controller_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ash/display/shared_display_edge_indicator.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/display/window_tree_host_manager.cc View 1 2 3 9 chunks +11 lines, -10 lines 0 comments Download
M ash/display/window_tree_host_manager_unittest.cc View 1 2 27 chunks +97 lines, -80 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M ash/first_run/first_run_helper_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ash/frame/caption_buttons/frame_size_button_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/screen_util.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M ash/shelf/overflow_bubble_view.cc View 2 chunks +8 lines, -4 lines 0 comments Download
M ash/shelf/shelf_bezel_event_filter.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_layout_manager_unittest.cc View 12 chunks +32 lines, -20 lines 0 comments Download
M ash/shelf/shelf_window_watcher.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shell.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 2 2 chunks +1 line, -6 lines 0 comments Download
M ash/shell/content/client/shell_browser_main_parts.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ash/shell/toplevel_window.cc View 1 1 chunk +1 line, -5 lines 0 comments Download
M ash/system/audio/tray_audio.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/web_notification/ash_popup_alignment_delegate_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/system/web_notification/web_notification_tray.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ash/system/web_notification/web_notification_tray_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/test/ash_test_base.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ash/test/ui_controls_factory_ash.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/touch/touch_observer_hud_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/utility/partial_screenshot_controller.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/ash_native_cursor_manager_unittest.cc View 1 chunk +10 lines, -7 lines 0 comments Download
M ash/wm/coordinate_conversion.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/default_state.cc View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager.cc View 5 chunks +14 lines, -10 lines 0 comments Download
M ash/wm/dock/docked_window_layout_manager_unittest.cc View 9 chunks +11 lines, -10 lines 0 comments Download
M ash/wm/dock/docked_window_resizer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ash/wm/drag_window_resizer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/drag_window_resizer_unittest.cc View 1 2 3 17 chunks +17 lines, -17 lines 0 comments Download
M ash/wm/immersive_fullscreen_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 6 chunks +9 lines, -6 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager_unittest.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M ash/wm/overview/window_selector.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/wm/panels/panel_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/toplevel_window_event_handler_unittest.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M ash/wm/window_animations.cc View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ash/wm/window_manager_unittest.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/wm/window_positioner.cc View 1 2 chunks +10 lines, -5 lines 0 comments Download
M ash/wm/window_positioner_unittest.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ash/wm/window_resizer.cc View 4 chunks +12 lines, -7 lines 0 comments Download
M ash/wm/window_state_unittest.cc View 1 2 3 7 chunks +7 lines, -7 lines 0 comments Download
M ash/wm/workspace/multi_window_resize_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler_unittest.cc View 4 chunks +12 lines, -8 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 10 chunks +29 lines, -20 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_window_resizer_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M ash/wm/workspace_controller_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/accessibility/chromevox_panel.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_mode_idle_app_name_notification.cc View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/display/display_preferences_unittest.cc View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/input_method/mode_indicator_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/lock/webui_screen_locker.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_web_dialog.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_aura.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos.cc View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_chromeos_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_mac.cc View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/display_info_provider_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/display_info_provider_win.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/ui/ash/launcher/browser_status_monitor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 2 4 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc View 1 2 3 2 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/system_display/display_info_provider.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/browser/api/system_info/system_info_api.cc View 1 2 3 chunks +2 lines, -3 lines 0 comments Download
M extensions/shell/browser/shell_display_info_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/shell/browser/shell_display_info_provider.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 1608733002 Patch 220002

Messages

Total messages: 17 (9 generated)
scottmg
4 years, 11 months ago (2016-01-20 01:24:04 UTC) #5
sky
LGTM https://codereview.chromium.org/1608053002/diff/20001/ash/display/screen_ash_unittest.cc File ash/display/screen_ash_unittest.cc (right): https://codereview.chromium.org/1608053002/diff/20001/ash/display/screen_ash_unittest.cc#newcode18 ash/display/screen_ash_unittest.cc:18: static gfx::Screen* Screen() { return gfx::Screen::GetScreen(); } Nuke ...
4 years, 11 months ago (2016-01-20 04:44:27 UTC) #6
oshima
lgtm with nits https://codereview.chromium.org/1608053002/diff/20001/ash/display/event_transformation_handler.cc File ash/display/event_transformation_handler.cc (right): https://codereview.chromium.org/1608053002/diff/20001/ash/display/event_transformation_handler.cc#newcode11 ash/display/event_transformation_handler.cc:11: #include "ash/shell.h" nit: can we remove ...
4 years, 11 months ago (2016-01-20 06:40:12 UTC) #7
scottmg
Thanks. +asargent for extensions/. https://codereview.chromium.org/1608053002/diff/20001/ash/display/event_transformation_handler.cc File ash/display/event_transformation_handler.cc (right): https://codereview.chromium.org/1608053002/diff/20001/ash/display/event_transformation_handler.cc#newcode11 ash/display/event_transformation_handler.cc:11: #include "ash/shell.h" On 2016/01/20 06:40:12, ...
4 years, 11 months ago (2016-01-26 20:46:35 UTC) #9
asargent_no_longer_on_chrome
extensions lgtm
4 years, 11 months ago (2016-01-26 22:20:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1608053002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1608053002/60001
4 years, 11 months ago (2016-01-27 04:21:15 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-27 05:07:43 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 05:08:56 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/e8b0429751298d4bff935658ad0501597bedfb54
Cr-Commit-Position: refs/heads/master@{#371733}

Powered by Google App Engine
This is Rietveld 408576698