Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: ash/dip_unittest.cc

Issue 1608053002: Remove now-unnecessary wrappers around gfx::Screen::GetScreen() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@metro-mode-5
Patch Set: cros Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <algorithm> 5 #include <algorithm>
6 #include <vector> 6 #include <vector>
7 7
8 #include "ash/ash_switches.h" 8 #include "ash/ash_switches.h"
9 #include "ash/display/display_manager.h" 9 #include "ash/display/display_manager.h"
10 #include "ash/shelf/shelf.h" 10 #include "ash/shelf/shelf.h"
(...skipping 19 matching lines...) Expand all
30 namespace ash { 30 namespace ash {
31 31
32 typedef ash::test::AshTestBase DIPTest; 32 typedef ash::test::AshTestBase DIPTest;
33 33
34 // Test if the WM sets correct work area under different density. 34 // Test if the WM sets correct work area under different density.
35 TEST_F(DIPTest, WorkArea) { 35 TEST_F(DIPTest, WorkArea) {
36 UpdateDisplay("1000x900*1.0f"); 36 UpdateDisplay("1000x900*1.0f");
37 37
38 aura::Window* root = Shell::GetPrimaryRootWindow(); 38 aura::Window* root = Shell::GetPrimaryRootWindow();
39 const gfx::Display display = 39 const gfx::Display display =
40 Shell::GetScreen()->GetDisplayNearestWindow(root); 40 gfx::Screen::GetScreen()->GetDisplayNearestWindow(root);
41 41
42 EXPECT_EQ("0,0 1000x900", display.bounds().ToString()); 42 EXPECT_EQ("0,0 1000x900", display.bounds().ToString());
43 gfx::Rect work_area = display.work_area(); 43 gfx::Rect work_area = display.work_area();
44 EXPECT_EQ("0,0 1000x853", work_area.ToString()); 44 EXPECT_EQ("0,0 1000x853", work_area.ToString());
45 EXPECT_EQ("0,0,47,0", display.bounds().InsetsFrom(work_area).ToString()); 45 EXPECT_EQ("0,0,47,0", display.bounds().InsetsFrom(work_area).ToString());
46 46
47 UpdateDisplay("2000x1800*2.0f"); 47 UpdateDisplay("2000x1800*2.0f");
48 gfx::Screen* screen = Shell::GetScreen(); 48 gfx::Screen* screen = gfx::Screen::GetScreen();
49 49
50 const gfx::Display display_2x = screen->GetDisplayNearestWindow(root); 50 const gfx::Display display_2x = screen->GetDisplayNearestWindow(root);
51 const DisplayInfo display_info_2x = 51 const DisplayInfo display_info_2x =
52 Shell::GetInstance()->display_manager()->GetDisplayInfo(display_2x.id()); 52 Shell::GetInstance()->display_manager()->GetDisplayInfo(display_2x.id());
53 53
54 // The |bounds_in_pixel()| should report bounds in pixel coordinate. 54 // The |bounds_in_pixel()| should report bounds in pixel coordinate.
55 EXPECT_EQ("1,1 2000x1800", 55 EXPECT_EQ("1,1 2000x1800",
56 display_info_2x.bounds_in_native().ToString()); 56 display_info_2x.bounds_in_native().ToString());
57 57
58 // Aura and views coordinates are in DIP, so they their bounds do not change. 58 // Aura and views coordinates are in DIP, so they their bounds do not change.
59 EXPECT_EQ("0,0 1000x900", display_2x.bounds().ToString()); 59 EXPECT_EQ("0,0 1000x900", display_2x.bounds().ToString());
60 work_area = display_2x.work_area(); 60 work_area = display_2x.work_area();
61 EXPECT_EQ("0,0 1000x853", work_area.ToString()); 61 EXPECT_EQ("0,0 1000x853", work_area.ToString());
62 EXPECT_EQ("0,0,47,0", display_2x.bounds().InsetsFrom(work_area).ToString()); 62 EXPECT_EQ("0,0,47,0", display_2x.bounds().InsetsFrom(work_area).ToString());
63 63
64 // Sanity check if the workarea's inset hight is same as 64 // Sanity check if the workarea's inset hight is same as
65 // the shelf's height. 65 // the shelf's height.
66 Shelf* shelf = Shelf::ForPrimaryDisplay(); 66 Shelf* shelf = Shelf::ForPrimaryDisplay();
67 EXPECT_EQ( 67 EXPECT_EQ(
68 display_2x.bounds().InsetsFrom(work_area).height(), 68 display_2x.bounds().InsetsFrom(work_area).height(),
69 shelf->shelf_widget()->GetNativeView()->layer()->bounds().height()); 69 shelf->shelf_widget()->GetNativeView()->layer()->bounds().height());
70 } 70 }
71 71
72 } // namespace ash 72 } // namespace ash
OLDNEW
« no previous file with comments | « ash/desktop_background/desktop_background_view.cc ('k') | ash/display/cursor_window_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698