Remove ui/gfx/screen_type_delegate.h

Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054
Committed: https://crrev.com/fb33c340bd50b0e8a5c874e5d7c10a6361cee126
Cr-Commit-Position: refs/heads/master@{#371676}

[scottmg, 2016-01-19 19:35:31]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[scottmg, 2016-01-19 19:35:31]

scottmg@chromium.org changed reviewers:
+ oshima@chromium.org, sky@chromium.org

[scottmg, 2016-01-19 19:37:24]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/_ALTERNATE, and there is
now only one Screen instance (still pluggable for tests).

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[scottmg, 2016-01-19 19:38:05]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/_ALTERNATE, and there is
now only one Screen instance (still pluggable for tests).

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance in normal usage. It's still a
runtime-installed thing for tests though.

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[scottmg, 2016-01-19 19:38:23]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance in normal usage. It's still a
runtime-installed thing for tests though.

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[scottmg, 2016-01-19 19:53:43]

Sorry it got so big, but most of it is very simple. The removal is in
ui/gfx/screen which meant renaming a few methods to make sense, which meant
touching a lot of files.

In the tooltip code, I also removed a now-unnecessary argument to GetMaxWidth()
that was only used to pass around to get the right Screen. I thought there would
be more like this, but I didn't notice any other obvious ones.

[oshima, 2016-01-19 20:44:32]

lgtm with nits

https://codereview.chromium.org/1608733002/diff/80001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ash/shell.cc#newcode245
ash/shell.cc:245: gfx::Screen* Shell::GetScreen() {
This is no longer useful. I'll remove it in a separate CL.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_aura.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_aura.cc:35: gfx::Screen*
DisplayInfoProviderAura::GetActiveScreen() {
We probably can remove this too.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/manifest...
File chrome/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/manifest...
chrome/browser/manifest/manifest_icon_downloader.cc:58: const gfx::Screen*
screen = gfx::Screen::GetScreen();
inline?

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/app_list/win/app_list_win.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/app_list/win/app_list_win.cc:83: gfx::Screen* screen =
gfx::Screen::GetScreen();
move this line above the first one?

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/window_finder_x11.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/window_finder_x11.cc:15: return
display.device_scale_factor();
can this be single line?

https://codereview.chromium.org/1608733002/diff/80001/ui/base/layout.cc
File ui/base/layout.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/base/layout.cc#newco...
ui/base/layout.cc:119: gfx::Display display =
screen->GetDisplayNearestWindow(view);
single line?

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/x11_window_event_filter.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/x11_window_event_filter.cc:156:
screen->GetDisplayNearestWindow(target).work_area();
inline?

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/tooltip...
File ui/views/widget/tooltip_manager_aura.h (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/tooltip...
ui/views/widget/tooltip_manager_aura.h:54: aura::Window* GetWindow() const;
I believe this const is intentional (as it returns non const internal object)

[scottmg, 2016-01-19 21:55:58]

https://codereview.chromium.org/1608733002/diff/80001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ash/shell.cc#newcode245
ash/shell.cc:245: gfx::Screen* Shell::GetScreen() {
On 2016/01/19 20:44:31, oshima wrote:
> This is no longer useful. I'll remove it in a separate CL.

OK, thanks.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_aura.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_aura.cc:35: gfx::Screen*
DisplayInfoProviderAura::GetActiveScreen() {
On 2016/01/19 20:44:31, oshima wrote:
> We probably can remove this too.

OK, I'll investigate that in a followup too.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/manifest...
File chrome/browser/manifest/manifest_icon_downloader.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/manifest...
chrome/browser/manifest/manifest_icon_downloader.cc:58: const gfx::Screen*
screen = gfx::Screen::GetScreen();
On 2016/01/19 20:44:31, oshima wrote:
> inline?

Done.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/app_list/win/app_list_win.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/app_list/win/app_list_win.cc:83: gfx::Screen* screen =
gfx::Screen::GetScreen();
On 2016/01/19 20:44:31, oshima wrote:
> move this line above the first one?

Done.

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
File chrome/browser/ui/views/tabs/window_finder_x11.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/ui/views...
chrome/browser/ui/views/tabs/window_finder_x11.cc:15: return
display.device_scale_factor();
On 2016/01/19 20:44:31, oshima wrote:
> can this be single line?

Done.

https://codereview.chromium.org/1608733002/diff/80001/ui/base/layout.cc
File ui/base/layout.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/base/layout.cc#newco...
ui/base/layout.cc:119: gfx::Display display =
screen->GetDisplayNearestWindow(view);
On 2016/01/19 20:44:31, oshima wrote:
> single line?

Done.

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/desktop...
File ui/views/widget/desktop_aura/x11_window_event_filter.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/desktop...
ui/views/widget/desktop_aura/x11_window_event_filter.cc:156:
screen->GetDisplayNearestWindow(target).work_area();
On 2016/01/19 20:44:31, oshima wrote:
> inline?

Done.

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/tooltip...
File ui/views/widget/tooltip_manager_aura.h (right):

https://codereview.chromium.org/1608733002/diff/80001/ui/views/widget/tooltip...
ui/views/widget/tooltip_manager_aura.h:54: aura::Window* GetWindow() const;
On 2016/01/19 20:44:31, oshima wrote:
> I believe this const is intentional (as it returns non const internal object)

Undid that.

[scottmg, 2016-01-19 21:58:32]

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
File chrome/browser/extensions/display_info_provider_aura.cc (right):

https://codereview.chromium.org/1608733002/diff/80001/chrome/browser/extensio...
chrome/browser/extensions/display_info_provider_aura.cc:35: gfx::Screen*
DisplayInfoProviderAura::GetActiveScreen() {
On 2016/01/19 21:55:57, scottmg wrote:
> On 2016/01/19 20:44:31, oshima wrote:
> > We probably can remove this too.
> 
> OK, I'll investigate that in a followup too.

Actually, these two are related. I can do both of them in a follow up. I'll send
a CL in a bit.

[sky, 2016-01-19 22:47:55]

If any of these are too big for this patch, feel free to push to a future patch.

https://codereview.chromium.org/1608733002/diff/100001/ash/display/display_ma...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/ash/display/display_ma...
ash/display/display_manager.cc:152: if (!current || current ==
screen_for_shutdown) {
nit: nuke {}

https://codereview.chromium.org/1608733002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/ash/shell.cc#newcode245
ash/shell.cc:245: gfx::Screen* Shell::GetScreen() {
Can Shell::GetScreen be nuked entirely now and callers updated to use Screen
directly? Feel free to add a TODO if you don't want to do it in this patch.

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/banners...
File chrome/browser/banners/app_banner_data_fetcher.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/banners...
chrome/browser/banners/app_banner_data_fetcher.cc:345:
gfx::Screen::GetScreen());
Can the Screen argument be removed from FindBestMatchingIcon?

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/display_info_provider_aura.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/display_info_provider_aura.cc:36: return
gfx::Screen::GetScreen();
Can GetActiveScreen be nuked?

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/tabs/tab_drag_controller.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/tabs/tab_drag_controller.cc:266: screen_ =
gfx::Screen::GetScreen();
You should be able to nuke screen_ now and use gfx::Screen::GetScreen()
directly.

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer.cc:200:
screen_(gfx::Screen::GetScreen()),
Nuke screen_ here too.

https://codereview.chromium.org/1608733002/diff/100001/content/browser/media/...
File content/browser/media/capture/web_contents_video_capture_device_unittest.cc
(right):

https://codereview.chromium.org/1608733002/diff/100001/content/browser/media/...
content/browser/media/capture/web_contents_video_capture_device_unittest.cc:652:
gfx::Screen::SetScreenInstance(NULL);
nullptr.

https://codereview.chromium.org/1608733002/diff/100001/ui/gfx/screen.h
File ui/gfx/screen.h (right):

https://codereview.chromium.org/1608733002/diff/100001/ui/gfx/screen.h#newcode28
ui/gfx/screen.h:28: // Retrieves the single Screen object.
nit: constructor/destructor before static functions.

https://codereview.chromium.org/1608733002/diff/100001/ui/views/widget/toolti...
File ui/views/widget/tooltip_manager.h (right):

https://codereview.chromium.org/1608733002/diff/100001/ui/views/widget/toolti...
ui/views/widget/tooltip_manager.h:11: #include "ui/gfx/native_widget_types.h"
Hopefully you can remove this include now.

[scottmg, 2016-01-20 00:52:57]

https://codereview.chromium.org/1608733002/diff/100001/ash/display/display_ma...
File ash/display/display_manager.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/ash/display/display_ma...
ash/display/display_manager.cc:152: if (!current || current ==
screen_for_shutdown) {
On 2016/01/19 22:47:54, sky wrote:
> nit: nuke {}

Done.

https://codereview.chromium.org/1608733002/diff/100001/ash/shell.cc
File ash/shell.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/ash/shell.cc#newcode245
ash/shell.cc:245: gfx::Screen* Shell::GetScreen() {
On 2016/01/19 22:47:54, sky wrote:
> Can Shell::GetScreen be nuked entirely now and callers updated to use Screen
> directly? Feel free to add a TODO if you don't want to do it in this patch.

Yeah, it got pretty big, so pushed to
https://codereview.chromium.org/1608053002/ .

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/banners...
File chrome/browser/banners/app_banner_data_fetcher.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/banners...
chrome/browser/banners/app_banner_data_fetcher.cc:345:
gfx::Screen::GetScreen());
On 2016/01/19 22:47:54, sky wrote:
> Can the Screen argument be removed from FindBestMatchingIcon?

Done.

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/extensi...
File chrome/browser/extensions/display_info_provider_aura.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/extensi...
chrome/browser/extensions/display_info_provider_aura.cc:36: return
gfx::Screen::GetScreen();
On 2016/01/19 22:47:54, sky wrote:
> Can GetActiveScreen be nuked?

Pushed that one to https://codereview.chromium.org/1608053002/ too.

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/view...
File chrome/browser/ui/views/tabs/tab_drag_controller.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/view...
chrome/browser/ui/views/tabs/tab_drag_controller.cc:266: screen_ =
gfx::Screen::GetScreen();
On 2016/01/19 22:47:54, sky wrote:
> You should be able to nuke screen_ now and use gfx::Screen::GetScreen()
> directly.

Done.

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/wind...
File chrome/browser/ui/window_sizer/window_sizer.cc (right):

https://codereview.chromium.org/1608733002/diff/100001/chrome/browser/ui/wind...
chrome/browser/ui/window_sizer/window_sizer.cc:200:
screen_(gfx::Screen::GetScreen()),
On 2016/01/19 22:47:54, sky wrote:
> Nuke screen_ here too.

This one has a second constructor that passes in a fake Screen during tests. I
don't want to break something weird, so if you think that's not necessary I'll
take a look at that one in a followup separately.

https://codereview.chromium.org/1608733002/diff/100001/content/browser/media/...
File content/browser/media/capture/web_contents_video_capture_device_unittest.cc
(right):

https://codereview.chromium.org/1608733002/diff/100001/content/browser/media/...
content/browser/media/capture/web_contents_video_capture_device_unittest.cc:652:
gfx::Screen::SetScreenInstance(NULL);
On 2016/01/19 22:47:54, sky wrote:
> nullptr.

Done.

https://codereview.chromium.org/1608733002/diff/100001/ui/gfx/screen.h
File ui/gfx/screen.h (right):

https://codereview.chromium.org/1608733002/diff/100001/ui/gfx/screen.h#newcode28
ui/gfx/screen.h:28: // Retrieves the single Screen object.
On 2016/01/19 22:47:55, sky wrote:
> nit: constructor/destructor before static functions.

Done.

https://codereview.chromium.org/1608733002/diff/100001/ui/views/widget/toolti...
File ui/views/widget/tooltip_manager.h (right):

https://codereview.chromium.org/1608733002/diff/100001/ui/views/widget/toolti...
ui/views/widget/tooltip_manager.h:11: #include "ui/gfx/native_widget_types.h"
On 2016/01/19 22:47:55, sky wrote:
> Hopefully you can remove this include now.

Done.

[sky, 2016-01-20 00:58:14]

LGTM

[scottmg, 2016-01-20 01:00:26]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-01-20 01:00:26]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1608733002/#ps120001
(title: "fixes2")

[commit-bot: I haz the power, 2016-01-20 01:04:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/120001

[commit-bot: I haz the power, 2016-01-20 01:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:19:41]

Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[scottmg, 2016-01-20 01:29:50]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-01-20 01:29:51]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1608733002/#ps140001
(title: "linux")

[commit-bot: I haz the power, 2016-01-20 01:34:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/140001

[commit-bot: I haz the power, 2016-01-20 01:45:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 01:45:09]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2016-01-25 21:40:26]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 21:44:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/240001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/240001

[scottmg, 2016-01-25 21:52:18]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 21:54:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/260001

[commit-bot: I haz the power, 2016-01-25 22:11:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:11:27]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-01-25 22:26:05]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 22:28:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/280001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/280001

[commit-bot: I haz the power, 2016-01-25 22:47:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:47:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[scottmg, 2016-01-25 23:10:19]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 23:11:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/300001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/300001

[commit-bot: I haz the power, 2016-01-25 23:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 23:28:52]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scottmg, 2016-01-26 00:09:55]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 00:15:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/320001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/320001

[scottmg, 2016-01-26 00:28:09]

The CQ bit was unchecked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-01-26 00:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 00:28:37]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2016-01-26 00:29:38]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 00:30:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/340001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/340001

[scottmg, 2016-01-26 00:43:09]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 00:44:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/360001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/360001

[scottmg, 2016-01-26 01:03:46]

The CQ bit was unchecked by scottmg@chromium.org

[scottmg, 2016-01-26 01:05:36]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 01:07:44]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[commit-bot: I haz the power, 2016-01-26 01:08:02]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/380001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/380001

[scottmg, 2016-01-26 01:29:23]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 01:33:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/400001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/400001

[commit-bot: I haz the power, 2016-01-26 02:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 02:11:38]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[scottmg, 2016-01-26 06:06:20]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 06:07:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/420001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/420001

[commit-bot: I haz the power, 2016-01-26 06:40:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 06:40:33]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scottmg, 2016-01-26 16:22:04]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 16:22:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/440001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/440001

[scottmg, 2016-01-26 16:47:06]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 16:47:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/460001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/460001

[scottmg, 2016-01-26 17:54:32]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-26 17:55:18]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/220002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/220002

[scottmg, 2016-01-26 18:39:59]

scottmg@chromium.org changed reviewers:
+ jam@chromium.org

[scottmg, 2016-01-26 18:40:01]

+jam for toplevel owners.

There's some files I'm missing owners for, but they're all just simple changes
to get this refactor landed. Removing an unused argument, renaming
GetNativeScreen() to GetScreen(), etc. The full list of non-owners'ed files is:

    blimp/engine/browser/blimp_engine_session.cc
    chromecast/browser/cast_browser_main_parts.cc
    chromecast/browser/cast_content_window.cc
    components/autofill/content/browser/risk/fingerprint.cc
    components/dom_distiller/content/browser/distiller_page_web_contents.cc
    components/metrics/ui/screen_info_metrics_provider.cc
    content/browser/media/capture/web_contents_video_capture_device_unittest.cc
    content/browser/renderer_host/render_widget_host_unittest.cc
    content/browser/renderer_host/render_widget_host_view_android.cc
    content/browser/renderer_host/render_widget_host_view_aura.cc
    content/browser/renderer_host/render_widget_host_view_base.cc
    content/browser/renderer_host/render_widget_host_view_mac.mm
    content/browser/web_contents/web_contents_view_aura.cc
    content/common/page_state_serialization.cc
    content/shell/browser/shell_aura.cc
    content/shell/browser/shell_views.cc
    extensions/browser/api/capture_web_contents_function.cc
    extensions/browser/api/system_display/display_info_provider.cc
    extensions/browser/api/system_display/system_display_apitest.cc
    extensions/browser/app_window/app_window.cc
    extensions/shell/browser/shell_desktop_controller_aura.cc
    extensions/shell/browser/shell_desktop_controller_mac.mm
    media/capture/video/linux/video_capture_device_chromeos.cc

[commit-bot: I haz the power, 2016-01-26 19:35:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-26 19:35:45]

Dry run: This issue passed the CQ dry run.

[jam, 2016-01-26 23:44:16]

On 2016/01/26 18:40:01, scottmg wrote:
> +jam for toplevel owners.
> 
> There's some files I'm missing owners for, but they're all just simple changes
> to get this refactor landed. Removing an unused argument, renaming
> GetNativeScreen() to GetScreen(), etc. The full list of non-owners'ed files
is:
> 
>     blimp/engine/browser/blimp_engine_session.cc
>     chromecast/browser/cast_browser_main_parts.cc
>     chromecast/browser/cast_content_window.cc
>     components/autofill/content/browser/risk/fingerprint.cc
>     components/dom_distiller/content/browser/distiller_page_web_contents.cc
>     components/metrics/ui/screen_info_metrics_provider.cc
>    
content/browser/media/capture/web_contents_video_capture_device_unittest.cc
>     content/browser/renderer_host/render_widget_host_unittest.cc
>     content/browser/renderer_host/render_widget_host_view_android.cc
>     content/browser/renderer_host/render_widget_host_view_aura.cc
>     content/browser/renderer_host/render_widget_host_view_base.cc
>     content/browser/renderer_host/render_widget_host_view_mac.mm
>     content/browser/web_contents/web_contents_view_aura.cc
>     content/common/page_state_serialization.cc
>     content/shell/browser/shell_aura.cc
>     content/shell/browser/shell_views.cc
>     extensions/browser/api/capture_web_contents_function.cc
>     extensions/browser/api/system_display/display_info_provider.cc
>     extensions/browser/api/system_display/system_display_apitest.cc
>     extensions/browser/app_window/app_window.cc
>     extensions/shell/browser/shell_desktop_controller_aura.cc
>     extensions/shell/browser/shell_desktop_controller_mac.mm
>     media/capture/video/linux/video_capture_device_chromeos.cc

per
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
you can just TBR

[scottmg, 2016-01-26 23:47:55]

On 2016/01/26 23:44:16, jam wrote:
> On 2016/01/26 18:40:01, scottmg wrote:
> > +jam for toplevel owners.
> > 
> > There's some files I'm missing owners for, but they're all just simple
changes
> > to get this refactor landed. Removing an unused argument, renaming
> > GetNativeScreen() to GetScreen(), etc. The full list of non-owners'ed files
> is:
> > 
> >     blimp/engine/browser/blimp_engine_session.cc
> >     chromecast/browser/cast_browser_main_parts.cc
> >     chromecast/browser/cast_content_window.cc
> >     components/autofill/content/browser/risk/fingerprint.cc
> >     components/dom_distiller/content/browser/distiller_page_web_contents.cc
> >     components/metrics/ui/screen_info_metrics_provider.cc
> >    
> content/browser/media/capture/web_contents_video_capture_device_unittest.cc
> >     content/browser/renderer_host/render_widget_host_unittest.cc
> >     content/browser/renderer_host/render_widget_host_view_android.cc
> >     content/browser/renderer_host/render_widget_host_view_aura.cc
> >     content/browser/renderer_host/render_widget_host_view_base.cc
> >     content/browser/renderer_host/render_widget_host_view_mac.mm
> >     content/browser/web_contents/web_contents_view_aura.cc
> >     content/common/page_state_serialization.cc
> >     content/shell/browser/shell_aura.cc
> >     content/shell/browser/shell_views.cc
> >     extensions/browser/api/capture_web_contents_function.cc
> >     extensions/browser/api/system_display/display_info_provider.cc
> >     extensions/browser/api/system_display/system_display_apitest.cc
> >     extensions/browser/app_window/app_window.cc
> >     extensions/shell/browser/shell_desktop_controller_aura.cc
> >     extensions/shell/browser/shell_desktop_controller_mac.mm
> >     media/capture/video/linux/video_capture_device_chromeos.cc
> 
> per
>
https://www.chromium.org/developers/owners-files#TOC-When-to-use-To-Be-Review...
> you can just TBR

Thanks, I'll do that.

[scottmg, 2016-01-26 23:52:47]

scottmg@chromium.org changed reviewers:
+ asargent@chromium.org, asvitkine@chromium.org, gcasto@chromium.org,
gunsch@chromium.org, nyquist@chromium.org, tommi@chromium.org, wez@chromium.org

[scottmg, 2016-01-26 23:52:49]

tbr'ing for a bunch of trivial changes:

wez: blimp/ 
gunsch: chromecast/
gcasto: components/autofill
nyquist: components\dom_distiller
asvitkine: components/metrics
jam: content/
asargent: extensions/
tommi: media/capture/video

[scottmg, 2016-01-26 23:53:10]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[scottmg, 2016-01-26 23:53:22]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-01-26 23:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org,
sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1608733002/#ps220002
(title: "android")

[commit-bot: I haz the power, 2016-01-26 23:56:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/220002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/220002

[tommi (sloooow) - chröme, 2016-01-27 00:01:53]

lgtm

[Wez, 2016-01-27 00:02:17]

lgtm

[commit-bot: I haz the power, 2016-01-27 00:09:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-27 00:09:22]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[scottmg, 2016-01-27 00:20:12]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-01-27 00:20:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@chromium.org,
sky@chromium.org, wez@chromium.org, oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/1608733002/#ps490001
(title: "and another rebase")

[commit-bot: I haz the power, 2016-01-27 00:21:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1608733002/490001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1608733002/490001

[nyquist, 2016-01-27 01:17:27]

components/dom_distiller lgtm

[commit-bot: I haz the power, 2016-01-27 01:30:45]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

[commit-bot: I haz the power, 2016-01-27 01:30:47]

Committed patchset #26 (id:490001)

[commit-bot: I haz the power, 2016-01-27 01:32:05]

Description was changed from

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054
==========

to

==========
Remove ui/gfx/screen_type_delegate.h

This removes gfx::SCREEN_TYPE_NATIVE/SCREEN_TYPE_ALTERNATE, and there is
now only one Screen instance. It's still a runtime-installed thing for
test purposes.

TBR=various owners for trivial changes
R=oshima@chromium.org, sky@chromium.org
BUG=558054

Committed: https://crrev.com/fb33c340bd50b0e8a5c874e5d7c10a6361cee126
Cr-Commit-Position: refs/heads/master@{#371676}
==========

[commit-bot: I haz the power, 2016-01-27 01:32:07]

Patchset 26 (id:??) landed as
https://crrev.com/fb33c340bd50b0e8a5c874e5d7c10a6361cee126
Cr-Commit-Position: refs/heads/master@{#371676}