Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 1598523002: GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic (Closed)

Created:
4 years, 11 months ago by Roland McGrath
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, brettw, Nico
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic crrev.com/365770 tried to avoid the -mstackrealign flag for building the breakpad code, but the GN changes there were not valid. This change refactors the problematic -mstackrealign (and related -mstack-alignment=16) flags out of compiler_codegen into its own config that can be removed for components building breakpad code. BUG=418554, 556393 R=brettw@chromium.org, thestig@chromium.org Committed: https://crrev.com/8a97d7152b60975275c88ad070677d5a75f344e7 Cr-Commit-Position: refs/heads/master@{#370464}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -22 lines) Patch
M breakpad/BUILD.gn View 2 chunks +8 lines, -12 lines 0 comments Download
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +14 lines, -4 lines 0 comments Download
M components/crash/content/app/BUILD.gn View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Roland McGrath
4 years, 11 months ago (2016-01-15 22:51:39 UTC) #1
Nico
lgtm
4 years, 11 months ago (2016-01-15 22:56:06 UTC) #3
Lei Zhang
lgtm, thanks!
4 years, 11 months ago (2016-01-15 23:05:55 UTC) #4
Roland McGrath
brettw: need OWNERS review for BUILDCONFIG.gn Thanks, Roland
4 years, 11 months ago (2016-01-15 23:08:46 UTC) #5
brettw
lgtm
4 years, 11 months ago (2016-01-19 23:27:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1598523002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1598523002/1
4 years, 11 months ago (2016-01-20 18:40:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-20 20:09:06 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 20:09:51 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a97d7152b60975275c88ad070677d5a75f344e7
Cr-Commit-Position: refs/heads/master@{#370464}

Powered by Google App Engine
This is Rietveld 408576698