Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: breakpad/BUILD.gn

Issue 1598523002: GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: breakpad/BUILD.gn
diff --git a/breakpad/BUILD.gn b/breakpad/BUILD.gn
index 231abcc26ac73d23c759fc3011c5ac6f640684f9..0b4bffcd0d4372c368d02cd78cdf2e5f4f2d0bd7 100644
--- a/breakpad/BUILD.gn
+++ b/breakpad/BUILD.gn
@@ -554,12 +554,10 @@ if (is_linux || is_android) {
cflags = [ "-marm" ]
}
- if (current_cpu == "x86" && is_clang) {
- # Clang's -mstackrealign doesn't work well with
- # linux_syscall_support.h hand written asm syscalls.
- # See https://crbug.com/556393
- cflags -= [ "-mstackrealign" ]
- }
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ configs -= [ "//build/config/compiler:clang_stackrealign" ]
if (is_android) {
sources += [ "src/common/android/breakpad_getcontext.S" ]
@@ -667,12 +665,10 @@ if (is_linux || is_android) {
include_dirs += [ "src/common/android/include" ]
}
- if (current_cpu == "x86" && is_clang) {
- # Clang's -mstackrealign doesn't work well with
- # linux_syscall_support.h hand written asm syscalls.
- # See https://crbug.com/556393
- cflags -= [ "-mstackrealign" ]
- }
+ # Clang's -mstackrealign doesn't work well with
+ # linux_syscall_support.h hand written asm syscalls.
+ # See https://crbug.com/556393
+ configs -= [ "//build/config/compiler:clang_stackrealign" ]
}
executable("linux_dumper_unittest_helper") {
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698