Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Side by Side Diff: components/crash/content/app/BUILD.gn

Issue 1598523002: GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 source_set("lib") { 9 source_set("lib") {
10 sources = [ 10 sources = [
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 "//base:base_static", 109 "//base:base_static",
110 "//components/crash/core/common", 110 "//components/crash/core/common",
111 "//content/public/common:content_descriptors", 111 "//content/public/common:content_descriptors",
112 "//content/public/common:result_codes", 112 "//content/public/common:result_codes",
113 ] 113 ]
114 114
115 if (is_android) { 115 if (is_android) {
116 defines += [ "CHROME_BUILD_ID=\"$android_chrome_build_id\"" ] 116 defines += [ "CHROME_BUILD_ID=\"$android_chrome_build_id\"" ]
117 } 117 }
118 118
119 if (current_cpu == "x86" && is_clang) { 119 # Clang's -mstackrealign doesn't work well with
120 # Clang's -mstackrealign doesn't work well with 120 # linux_syscall_support.h hand written asm syscalls.
121 # linux_syscall_support.h hand written asm syscalls. 121 # See https://crbug.com/556393
122 # See https://crbug.com/556393 122 configs -= [ "//build/config/compiler:clang_stackrealign" ]
123 cflags -= [ "-mstackrealign" ]
124 }
125 123
126 if (is_win) { 124 if (is_win) {
127 deps += [ 125 deps += [
128 "//breakpad:breakpad_handler", 126 "//breakpad:breakpad_handler",
129 "//sandbox", 127 "//sandbox",
130 128
131 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP) 129 #'../breakpad/breakpad.gyp:breakpad_sender', TODO(GYP)
132 ] 130 ]
133 } else if (is_posix && !is_ios) { 131 } else if (is_posix && !is_ios) {
134 deps += [ "//breakpad:client" ] 132 deps += [ "//breakpad:client" ]
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 167
170 if (is_mac) { 168 if (is_mac) {
171 deps += [ "//breakpad" ] 169 deps += [ "//breakpad" ]
172 } 170 }
173 171
174 if (is_win) { 172 if (is_win) {
175 deps += [ "//breakpad:breakpad_handler" ] 173 deps += [ "//breakpad:breakpad_handler" ]
176 } 174 }
177 } 175 }
178 } 176 }
OLDNEW
« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698