components/crash/content/app/BUILD.gn - Issue 1598523002: GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/BUILD.gn

Issue 1598523002: GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/app/BUILD.gn

diff --git a/components/crash/content/app/BUILD.gn b/components/crash/content/app/BUILD.gn

index 52140ce48d78a2cdfe8f5647fdcd920480c93ba2..f08809045b010d49c3b72828ef2db942df633d25 100644

--- a/components/crash/content/app/BUILD.gn

+++ b/components/crash/content/app/BUILD.gn

@@ -116,12 +116,10 @@ source_set("app_non_mac_win") {

defines += [ "CHROME_BUILD_ID=\"$android_chrome_build_id\"" ]

}

- if (current_cpu == "x86" && is_clang) {

- # Clang's -mstackrealign doesn't work well with

- # linux_syscall_support.h hand written asm syscalls.

- # See https://crbug.com/556393

- cflags -= [ "-mstackrealign" ]

- }

+ # Clang's -mstackrealign doesn't work well with

+ # linux_syscall_support.h hand written asm syscalls.

+ # See https://crbug.com/556393

+ configs -= [ "//build/config/compiler:clang_stackrealign" ]

if (is_win) {

deps += [

« no previous file with comments | « build/config/compiler/BUILD.gn ('k') | no next file » | no next file with comments »