GN: Move x86 Clang -mstackrealign workaround to its own config, elide it where problematic

breakpad/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/symlink.gni")
 import("//testing/test.gni")
 
 if (is_android) {
   import("//build/config/android/rules.gni")
 }
@@ skipping 536 matching lines @@
     configs -= [ "//build/config/compiler:chromium_code" ]
     configs += [ "//build/config/compiler:no_chromium_code" ]
     public_configs = [ ":client_config" ]
 
     if (current_cpu == "arm" && is_chromeos) {
       # Avoid running out of registers in
       # linux_syscall_support.h:sys_clone()'s inline assembly.
       cflags = [ "-marm" ]
     }
 
-    if (current_cpu == "x86" && is_clang) {
-      # Clang's -mstackrealign doesn't work well with
-      # linux_syscall_support.h hand written asm syscalls.
-      # See https://crbug.com/556393
-      cflags -= [ "-mstackrealign" ]
-    }
+    # Clang's -mstackrealign doesn't work well with
+    # linux_syscall_support.h hand written asm syscalls.
+    # See https://crbug.com/556393
+    configs -= [ "//build/config/compiler:clang_stackrealign" ]
 
     if (is_android) {
       sources += [ "src/common/android/breakpad_getcontext.S" ]
     }
 
     libs = [ "dl" ]
 
     include_dirs = [
       ".",
       "src",
@@ skipping 87 matching lines @@
       # See http://crbug.com/138571#c18
       cflags = [ "-Wno-unused-value" ]
     }
 
     if (is_android) {
       sources += [ "src/common/android/breakpad_getcontext_unittest.cc" ]
       libs = [ "log" ]
       include_dirs += [ "src/common/android/include" ]
     }
 
-    if (current_cpu == "x86" && is_clang) {
-      # Clang's -mstackrealign doesn't work well with
-      # linux_syscall_support.h hand written asm syscalls.
-      # See https://crbug.com/556393
-      cflags -= [ "-mstackrealign" ]
-    }
+    # Clang's -mstackrealign doesn't work well with
+    # linux_syscall_support.h hand written asm syscalls.
+    # See https://crbug.com/556393
+    configs -= [ "//build/config/compiler:clang_stackrealign" ]
   }
 
   executable("linux_dumper_unittest_helper") {
     set_sources_assignment_filter([])
     testonly = true
     sources = [
       "src/client/linux/minidump_writer/linux_dumper_unittest_helper.cc",
     ]
     deps = [
       ":processor_support",
@@ skipping 193 matching lines @@
     }
   }
 
   test_runner_script("breakpad_unittests__test_runner_script") {
     test_name = "breakpad_unittests"
     test_type = "gtest"
     test_suite = "breakpad_unittests"
     isolate_file = "breakpad_unittests.isolate"
   }
 }