Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 15979015: Reland 15721002: Hook up the device selection to the WebAudio live audio (Closed)

Created:
7 years, 6 months ago by no longer working on chromium
Modified:
7 years, 4 months ago
Reviewers:
Jeffrey Yasskin
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Try relanding this CL, the original CL passed the try bots but failed the mac 10.7 bot because the oroginal CL queried the device info while there is no device on the bot. Hook up the device selection to the WebAudio live audio. WebAudio live audio needs to pass the session_id to the browser process so that Chrome can open the correct input device for unitfied IO. This CL looks big because it touches quite some interfaces from the render to the browser. But the change is simple and basically adding a session_id/device_id to the classes. All the changes some together and it is very hard to break it down. It also makes the media output code more similar to the media input code as well, and it will be easier to merge them for the future. TBR=henrika@chormium.org BUG=147327 TEST=http://chromium.googlecode.com/svn/trunk/samples/audio/visualizer-live.html Change the device using the camera icon on the right of the omnibox, then reload. Verify the sound is coming from the correct input device. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203695

Patch Set 1 #

Patch Set 2 : fixed the comments. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -218 lines) Patch
M chrome/browser/notifications/notification_audio_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager.cc View 1 4 chunks +30 lines, -7 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_renderer_host.cc View 2 chunks +11 lines, -11 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 4 chunks +10 lines, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 7 chunks +33 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 7 chunks +60 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/media/audio_messages.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/audio_message_filter.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/media_stream_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/media/renderer_webaudiodevice_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/renderer/media/webrtc_audio_device_impl.h View 2 chunks +6 lines, -8 lines 0 comments Download
M content/renderer/pepper/pepper_platform_audio_output_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M content/test/webrtc_audio_device_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/android/audio_manager_android.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/android/audio_manager_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_manager.h View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_manager_base.h View 6 chunks +18 lines, -14 lines 0 comments Download
M media/audio/audio_manager_base.cc View 6 chunks +61 lines, -15 lines 2 comments Download
M media/audio/audio_output_controller.h View 3 chunks +8 lines, -2 lines 0 comments Download
M media/audio/audio_output_controller.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_device.h View 2 chunks +16 lines, -0 lines 0 comments Download
M media/audio/audio_output_device.cc View 3 chunks +12 lines, -4 lines 0 comments Download
M media/audio/audio_output_device_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M media/audio/audio_output_dispatcher.h View 3 chunks +6 lines, -1 line 0 comments Download
M media/audio/audio_output_dispatcher.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/audio_output_dispatcher_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/audio_output_ipc.h View 1 chunk +5 lines, -2 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 20 chunks +25 lines, -23 lines 0 comments Download
M media/audio/audio_output_resampler.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/audio/audio_output_resampler.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/audio_parameters.h View 1 chunk +10 lines, -0 lines 0 comments Download
M media/audio/cras/audio_manager_cras.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/cras/audio_manager_cras.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/ios/audio_manager_ios.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/ios/audio_manager_ios.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/linux/audio_manager_linux.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/linux/audio_manager_linux.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M media/audio/mock_audio_manager.h View 1 chunk +4 lines, -2 lines 0 comments Download
M media/audio/mock_audio_manager.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/openbsd/audio_manager_openbsd.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/pulse/audio_manager_pulse.h View 2 chunks +4 lines, -2 lines 0 comments Download
M media/audio/pulse/audio_manager_pulse.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M media/audio/pulse/pulse_unified.h View 3 chunks +5 lines, -0 lines 0 comments Download
M media/audio/pulse/pulse_unified.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.h View 1 chunk +2 lines, -1 line 0 comments Download
M media/audio/win/audio_manager_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 13 chunks +40 lines, -20 lines 0 comments Download
M media/audio/win/audio_unified_win.h View 2 chunks +5 lines, -1 line 0 comments Download
M media/audio/win/audio_unified_win.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M media/audio/win/audio_unified_win_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/base/audio_renderer_sink.h View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/15979015/67
7 years, 6 months ago (2013-06-03 10:49:20 UTC) #1
no longer working on chromium
Committed patchset #2 manually as r203695 (presubmit successful).
7 years, 6 months ago (2013-06-03 11:09:15 UTC) #2
Jeffrey Yasskin
https://codereview.chromium.org/15979015/diff/67/media/audio/audio_manager_base.cc File media/audio/audio_manager_base.cc (right): https://codereview.chromium.org/15979015/diff/67/media/audio/audio_manager_base.cc#newcode260 media/audio/audio_manager_base.cc:260: return new AudioOutputProxy(dispatcher.get()); This leaks the dispatcher_params. What did ...
7 years, 4 months ago (2013-08-07 23:00:47 UTC) #3
no longer working on chromium
7 years, 4 months ago (2013-08-08 08:34:59 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/15979015/diff/67/media/audio/audio_manager_ba...
File media/audio/audio_manager_base.cc (right):

https://codereview.chromium.org/15979015/diff/67/media/audio/audio_manager_ba...
media/audio/audio_manager_base.cc:260: return new
AudioOutputProxy(dispatcher.get());
On 2013/08/07 23:00:47, Jeffrey Yasskin wrote:
> This leaks the dispatcher_params. What did you mean to do with that object?
> 
> You should also add a direct test of this code path so that we'd find the leak
> faster. I saw it in
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Webkit%2520Linux%252...,
> but it doesn't look reliable there.

Oh, thanks for finding it out, I am making a CL to fix it now.
We do have tests for this MakeAudioOutputStreamProxy() API, but the reason why
they don't exercise the piece code is that we use AUDIO_FAKE stream on our bots,
in order to avoid opening real hardware devices.

Powered by Google App Engine
This is Rietveld 408576698