chrome/browser/notifications/notification_audio_controller.cc - Issue 15979015: Reland 15721002: Hook up the device selection to the WebAudio live audio

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_audio_controller.cc

Issue 15979015: Reland 15721002: Hook up the device selection to the WebAudio live audio (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fixed the comments. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/notifications/notification_audio_controller.cc

diff --git a/chrome/browser/notifications/notification_audio_controller.cc b/chrome/browser/notifications/notification_audio_controller.cc

index 4fd26c66e682e7f5d0f41092b5d07b4caf5ee48f..ec7f090c068b65ba3cd10f007370ee79e9e52882 100644

--- a/chrome/browser/notifications/notification_audio_controller.cc

+++ b/chrome/browser/notifications/notification_audio_controller.cc

@@ -251,7 +251,7 @@ bool NotificationAudioController::AudioHandler::StartPlayingSound(

if (!params.IsValid())

return false;

- stream_ = audio_manager_->MakeAudioOutputStreamProxy(params);

+ stream_ = audio_manager_->MakeAudioOutputStreamProxy(params, std::string());

if (!stream_->Open()) {

DLOG(ERROR) << "Failed to open the output stream";

stream_->Close();

« no previous file with comments | « no previous file | content/browser/renderer_host/media/audio_input_device_manager.cc » ('j') | media/audio/audio_manager_base.cc » ('J')