Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 159183002: Revert 250146 "Merge 249460 "Hookup clear_uniforms_before_first_..." (Closed)

Created:
6 years, 10 months ago by laforge
Modified:
6 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Revert 250146 "Merge 249460 "Hookup clear_uniforms_before_first_..." > Merge 249460 "Hookup clear_uniforms_before_first_program_use wor..." > > > Hookup clear_uniforms_before_first_program_use workaround with implementation. > > > > Right now it's hardwired in command buffer. > > > > BUG=340516, 333885 > > TEST=gpu_unittests, webgl conformance tests > > R=bajones@chromium.org, kbr@chromium.org > > > > Review URL: https://codereview.chromium.org/147593011 > > TBR=zmo@chromium.org > > Review URL: https://codereview.chromium.org/148153025 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -97 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +5 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 5 chunks +7 lines, -9 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 7 chunks +14 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
laforge
6 years, 10 months ago (2014-02-10 19:39:29 UTC) #1
laforge
6 years, 10 months ago (2014-02-10 19:40:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r250179.

Powered by Google App Engine
This is Rietveld 408576698