Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 147593011: Hookup clear_uniforms_before_first_program_use workaround with implementation. (Closed)

Created:
6 years, 10 months ago by Zhenyao Mo
Modified:
4 years, 6 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Hookup clear_uniforms_before_first_program_use workaround with implementation. Right now it's hardwired in command buffer. BUG=340516 TEST=gpu_unittests, webgl conformance tests R=bajones@chromium.org, kbr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249460

Patch Set 1 #

Total comments: 6

Patch Set 2 : revision per kbr comments #

Patch Set 3 : same #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -48 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 1 chunk +51 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 1 5 chunks +9 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 7 chunks +7 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +9 lines, -1 line 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 23 (1 generated)
Zhenyao Mo
kbr, bajones: please take a look.
6 years, 10 months ago (2014-02-04 05:10:17 UTC) #1
bajones
On 2014/02/04 05:10:17, Zhenyao Mo wrote: > kbr, bajones: please take a look. LGTM
6 years, 10 months ago (2014-02-04 18:51:22 UTC) #2
Ken Russell (switch to Gerrit)
On the right track overall, but a few issues. https://codereview.chromium.org/147593011/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (left): https://codereview.chromium.org/147593011/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc#oldcode1268 gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:1268: ...
6 years, 10 months ago (2014-02-04 22:15:11 UTC) #3
Zhenyao Mo
kbr: revised. please take a look. https://codereview.chromium.org/147593011/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc File gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc (left): https://codereview.chromium.org/147593011/diff/1/gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc#oldcode1268 gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc:1268: SetupExpectationsForClearingUniforms(uniforms, num_uniforms); On ...
6 years, 10 months ago (2014-02-05 02:02:41 UTC) #4
Zhenyao Mo
kbr: bots are green. please take a look when you find time.
6 years, 10 months ago (2014-02-06 01:20:29 UTC) #5
Ken Russell (switch to Gerrit)
Sorry for the delay. Very nice. LGTM
6 years, 10 months ago (2014-02-06 02:00:16 UTC) #6
Ken Russell (switch to Gerrit)
BTW, please update the CL description before committing.
6 years, 10 months ago (2014-02-06 02:00:42 UTC) #7
Zhenyao Mo
The CQ bit was checked by zmo@chromium.org
6 years, 10 months ago (2014-02-06 14:56:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zmo@chromium.org/147593011/340001
6 years, 10 months ago (2014-02-06 14:57:13 UTC) #9
commit-bot: I haz the power
Change committed as 249460
6 years, 10 months ago (2014-02-06 18:41:21 UTC) #10
jonnialva90
4 years, 7 months ago (2016-05-25 13:33:27 UTC) #12
jonnialva90
4 years, 7 months ago (2016-05-25 13:33:55 UTC) #13
jonnialva90
4 years, 7 months ago (2016-05-25 13:34:10 UTC) #14
jonnialva90
4 years, 7 months ago (2016-05-25 13:34:24 UTC) #15
jonnialva90
4 years, 7 months ago (2016-05-25 13:34:41 UTC) #16
jonnialva90
4 years, 7 months ago (2016-05-25 13:34:44 UTC) #17
jonnialva90
4 years, 7 months ago (2016-05-25 13:34:58 UTC) #18
jonnialva90
4 years, 7 months ago (2016-05-25 13:35:10 UTC) #19
jonnialva90
4 years, 7 months ago (2016-05-25 13:35:24 UTC) #20
jonnialva90
4 years, 7 months ago (2016-05-25 13:35:41 UTC) #21
jonnialva90
4 years, 7 months ago (2016-05-25 13:35:53 UTC) #22
jonnialva90
4 years, 7 months ago (2016-05-25 13:35:56 UTC) #23
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698