Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 148153025: Merge 249460 "Hookup clear_uniforms_before_first_program_use wor..." (Closed)

Created:
6 years, 10 months ago by Zhenyao Mo
Modified:
6 years, 10 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Visibility:
Public.

Description

Merge 249460 "Hookup clear_uniforms_before_first_program_use wor..." > Hookup clear_uniforms_before_first_program_use workaround with implementation. > > Right now it's hardwired in command buffer. > > BUG=340516, 333885 > TEST=gpu_unittests, webgl conformance tests > R=bajones@chromium.org, kbr@chromium.org > > Review URL: https://codereview.chromium.org/147593011 TBR=zmo@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250146

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -47 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 1 chunk +51 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_1.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/program_manager.h View 5 chunks +9 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 7 chunks +7 lines, -14 lines 0 comments Download
M gpu/command_buffer/service/program_manager_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zhenyao Mo
6 years, 10 months ago (2014-02-10 17:58:44 UTC) #1
Zhenyao Mo
6 years, 10 months ago (2014-02-10 17:59:22 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r250146.

Powered by Google App Engine
This is Rietveld 408576698