Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 158663002: IDL compiler: sync Python to r166688 (and clean up special operations+union code) (Closed)

Created:
6 years, 10 months ago by Nils Barth (inactive)
Modified:
6 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: sync Python to r166688 (and clean up special operations+union code) Python side to: Update HTMLFormControlsCollection's named getter to behave according to spec https://codereview.chromium.org/157013006 This also involves lots of cleaning up to special operations and union type code, making it more generic and avoiding duplication on the Python side. * Rename collection => imp * Rename element => result (for union type in/out variables) * Remove blank lines in nested code With a bit more cleaning (post-rewrite), special operations can use the default methods code generation with only minor changes! BUG=239771 TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166808

Patch Set 1 #

Patch Set 2 : Typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -215 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 13 chunks +24 lines, -24 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_interface.py View 4 chunks +27 lines, -16 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_methods.py View 1 5 chunks +44 lines, -16 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_types.py View 2 chunks +7 lines, -2 lines 0 comments Download
M Source/bindings/templates/interface.cpp View 12 chunks +18 lines, -33 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +24 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 4 chunks +15 lines, -19 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 4 chunks +12 lines, -12 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsIdentifierRaisesException.cpp View 8 chunks +20 lines, -20 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsInt.cpp View 6 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp View 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nils Barth (inactive)
6 years, 10 months ago (2014-02-10 06:41:03 UTC) #1
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 10 months ago (2014-02-10 06:41:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/158663002/20001
6 years, 10 months ago (2014-02-10 06:41:22 UTC) #3
haraken
LGTM
6 years, 10 months ago (2014-02-10 06:56:20 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 07:59:18 UTC) #5
Message was sent while issue was closed.
Change committed as 166808

Powered by Google App Engine
This is Rietveld 408576698