Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: Source/bindings/tests/results/V8TestObject.cpp

Issue 158663002: IDL compiler: sync Python to r166688 (and clean up special operations+union code) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Typo Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestObject.cpp
diff --git a/Source/bindings/tests/results/V8TestObject.cpp b/Source/bindings/tests/results/V8TestObject.cpp
index 8cd637b3423d9ce766b484d68d952363cac0daed..ed6a7a60648e8e768eecc8a0dd81e379b2b86c8d 100644
--- a/Source/bindings/tests/results/V8TestObject.cpp
+++ b/Source/bindings/tests/results/V8TestObject.cpp
@@ -5211,11 +5211,11 @@ static void deprecatedStaticMethodMethodCallback(const v8::FunctionCallbackInfo<
static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestObj* collection = V8TestObject::toNative(info.Holder());
- RefPtr<Node> element = collection->anonymousIndexedGetter(index);
- if (!element)
+ TestObj* imp = V8TestObject::toNative(info.Holder());
+ RefPtr<Node> result = imp->anonymousIndexedGetter(index);
+ if (!result)
return;
- v8SetReturnValueFast(info, element.release(), collection);
+ v8SetReturnValueFast(info, result.release(), imp);
}
static void indexedPropertyGetterCallback(uint32_t index, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -5234,12 +5234,12 @@ static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (info.Holder()->HasRealNamedProperty(name))
return;
- TestObj* collection = V8TestObject::toNative(info.Holder());
+ TestObj* imp = V8TestObject::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- String element = collection->anonymousNamedGetter(propertyName);
- if (element.isNull())
+ String result = imp->anonymousNamedGetter(propertyName);
+ if (result.isNull())
return;
- v8SetReturnValueString(info, element, info.GetIsolate());
+ v8SetReturnValueString(info, result, info.GetIsolate());
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -5251,10 +5251,10 @@ static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::Pr
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TestObj* collection = V8TestObject::toNative(info.Holder());
+ TestObj* imp = V8TestObject::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->namedPropertyQuery(propertyName, exceptionState);
+ bool result = imp->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -5271,10 +5271,10 @@ static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::Pro
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TestObj* collection = V8TestObject::toNative(info.Holder());
+ TestObj* imp = V8TestObject::toNative(info.Holder());
Vector<String> names;
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- collection->namedPropertyEnumerator(names, exceptionState);
+ imp->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;
v8::Handle<v8::Array> v8names = v8::Array::New(info.GetIsolate(), names.size());
« no previous file with comments | « Source/bindings/tests/results/V8TestInterface.cpp ('k') | Source/bindings/tests/results/V8TestSpecialOperationsAnonymous.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698