Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Unified Diff: Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp

Issue 158663002: IDL compiler: sync Python to r166688 (and clean up special operations+union code) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Typo Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp
diff --git a/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp b/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp
index 9781e261a31fa722bc235ccc6e2cdf09fa8af2fa..bc302c537d6c787eba2ea7d203ac9a5ee45a7570 100644
--- a/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp
+++ b/Source/bindings/tests/results/V8TestSpecialOperationsOverrideBuiltins.cpp
@@ -73,12 +73,12 @@ template <typename T> void V8_USE(T) { }
static void namedPropertyGetter(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsOverrideBuiltins* collection = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
+ TestSpecialOperationsOverrideBuiltins* imp = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
- String element = collection->anonymousNamedGetter(propertyName);
- if (element.isNull())
+ String result = imp->anonymousNamedGetter(propertyName);
+ if (result.isNull())
return;
- v8SetReturnValueString(info, element, info.GetIsolate());
+ v8SetReturnValueString(info, result, info.GetIsolate());
}
static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Value>& info)
@@ -90,10 +90,10 @@ static void namedPropertyGetterCallback(v8::Local<v8::String> name, const v8::Pr
static void namedPropertySetter(v8::Local<v8::String> name, v8::Local<v8::Value> jsValue, const v8::PropertyCallbackInfo<v8::Value>& info)
{
- TestSpecialOperationsOverrideBuiltins* collection = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
+ TestSpecialOperationsOverrideBuiltins* imp = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyName, name);
V8TRYCATCH_FOR_V8STRINGRESOURCE_VOID(V8StringResource<>, propertyValue, jsValue);
- bool result = collection->anonymousNamedSetter(propertyName, propertyValue);
+ bool result = imp->anonymousNamedSetter(propertyName, propertyValue);
if (!result)
return;
v8SetReturnValue(info, jsValue);
@@ -108,10 +108,10 @@ static void namedPropertySetterCallback(v8::Local<v8::String> name, v8::Local<v8
static void namedPropertyQuery(v8::Local<v8::String> name, const v8::PropertyCallbackInfo<v8::Integer>& info)
{
- TestSpecialOperationsOverrideBuiltins* collection = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
+ TestSpecialOperationsOverrideBuiltins* imp = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
AtomicString propertyName = toCoreAtomicString(name);
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- bool result = collection->namedPropertyQuery(propertyName, exceptionState);
+ bool result = imp->namedPropertyQuery(propertyName, exceptionState);
if (exceptionState.throwIfNeeded())
return;
if (!result)
@@ -128,10 +128,10 @@ static void namedPropertyQueryCallback(v8::Local<v8::String> name, const v8::Pro
static void namedPropertyEnumerator(const v8::PropertyCallbackInfo<v8::Array>& info)
{
- TestSpecialOperationsOverrideBuiltins* collection = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
+ TestSpecialOperationsOverrideBuiltins* imp = V8TestSpecialOperationsOverrideBuiltins::toNative(info.Holder());
Vector<String> names;
ExceptionState exceptionState(info.Holder(), info.GetIsolate());
- collection->namedPropertyEnumerator(names, exceptionState);
+ imp->namedPropertyEnumerator(names, exceptionState);
if (exceptionState.throwIfNeeded())
return;
v8::Handle<v8::Array> v8names = v8::Array::New(info.GetIsolate(), names.size());
« no previous file with comments | « Source/bindings/tests/results/V8TestSpecialOperationsNotEnumerable.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698